Skip to content

[Backport 1.5.latest] [Fix] safe version attribute access in _check_resource_uniqueness #7405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichelleArk merged 2 commits into from
Apr 20, 2023
Merged

[Backport 1.5.latest] [Fix] safe version attribute access in _check_resource_uniqueness #7405

MichelleArk merged 2 commits into from
Apr 20, 2023

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 18, 2023

Backport a87275a from #7376.

@MichelleArk @github-actions
[Fix] safe version attribute access in _check_resource_uniqueness (#7376
46dce89 
)

safe version attribute access in _check_resource_uniqueness

(cherry picked from commit a87275a)
@github-actions github-actions bot requested a review from a team April 18, 2023 18:28
@github-actions github-actions bot requested review from a team as code owners April 18, 2023 18:28
@cla-bot cla-bot bot added the cla:yes label Apr 18, 2023
@leahwicz leahwicz closed this Apr 18, 2023
@leahwicz leahwicz reopened this Apr 18, 2023
@leahwicz
Copy link
Contributor

leahwicz commented Apr 18, 2023 •
edited
Loading

@MichelleArk the more I think about this I think we should go ahead an backport this to 1.5 for the final release even if we don't see impact there. I would rather be proactive in case that other areas that are missing test coverage might be impacted. We can always revisit loosening this for future releases by them or completely removing the dependency all together CC @jtcohen6

aranke
aranke approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit.

@jtcohen6 jtcohen6 mentioned this pull request Apr 19, 2023
Merged
@MichelleArk MichelleArk merged commit f0530e6 into 1.5.latest Apr 20, 2023
@MichelleArk MichelleArk deleted the backport-7376-to-1.5.latest branch April 20, 2023 01:50
This was referenced Jun 14, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichelleArk MichelleArk MichelleArk left review comments

@peterallenwebb peterallenwebb Awaiting requested review from peterallenwebb peterallenwebb was automatically assigned from dbt-labs/core-team

+2 more reviewers

@aranke aranke aranke approved these changes

@leahwicz leahwicz leahwicz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla:yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leahwicz @MichelleArk @aranke