Do not rewrite manifest.json during docs serve command
#7554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
requested review from
VersusFacit and
emmyoop
and removed request for
a team
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2023
(cherry picked from commit 5a7b73b)
|
Thanks @jtcohen6 - amazingly fast response on this! |
jtcohen6
added a commit
that referenced
this pull request
May 9, 2023
(cherry picked from commit 5a7b73b) Co-authored-by: Jeremy Cohen <[email protected]>
This was referenced Jun 14, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7553
resolves #7922
Description
dbt docs serve"requires" a manifest, it will re-parse the project and (over)writemanifest.jsondbt docs generatedbt docs serve! dbt just expects it to exist, in thetarget/path, in already serialized (JSON) form.Checklist
This PR includes tests, or tests are not required/relevant for this PRI have opened an issue to add/update docs, or docs changes are not required/relevant for this PRchangie newto create a changelog entry