Skip to content

Honor --skip-profile-setup parameter when inside an existing project #7609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbeatty10 merged 9 commits into from
May 23, 2023
Merged

Honor --skip-profile-setup parameter when inside an existing project #7609

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c42eb19
Honor `--skip-profile-setup` parameter when inside an existing project
dbeatty10 May 11, 2023
1bc1f8c
Use project name as the profile name
dbeatty10 May 12, 2023
841a55d
Use separate file connections for reading and writing
dbeatty10 May 22, 2023
83cda4c
Raise a custom exception when no adapters are installed
dbeatty10 May 23, 2023
0d0f6d6
Test skipping interactive profile setup when inside a dbt project
dbeatty10 May 23, 2023
732e69c
Replace `assert_not_called()` since it does not work
dbeatty10 May 23, 2023
d8b0236
Verbose CLI argument for skipping profile setup
dbeatty10 May 23, 2023
79a083e
Use separate file connections for reading and writing
dbeatty10 May 23, 2023
4b82028
Check empty list in a Pythonic manner
dbeatty10 May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Verbose CLI argument for skipping profile setup
  • Loading branch information
@dbeatty10
dbeatty10 committed May 23, 2023
commit d8b02365f05c679d8347f8ddae8f2ef01b046e40
8 changes: 4 additions & 4 deletions tests/functional/init/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ def test_init_invalid_project_name_cli(
manager.prompt.side_effect = [valid_name]
mock_get_adapter.return_value = [project.adapter.type()]

run_dbt(["init", invalid_name, "-s"])
run_dbt(["init", invalid_name, "--skip-profile-setup"])
manager.assert_has_calls(
[
call.prompt("Enter a name for your project (letters, digits, underscore)"),
Expand All @@ -613,7 +613,7 @@ def test_init_invalid_project_name_prompt(
manager.prompt.side_effect = [invalid_name, valid_name]
mock_get_adapter.return_value = [project.adapter.type()]

run_dbt(["init", "-s"])
run_dbt(["init", "--skip-profile-setup"])
manager.assert_has_calls(
[
call.prompt("Enter a name for your project (letters, digits, underscore)"),
Expand Down Expand Up @@ -645,7 +645,7 @@ def test_init_provided_project_name_and_skip_profile_setup(
mock_get.return_value = [project.adapter.type()]

# provide project name through the init command
run_dbt(["init", project_name, "-s"])
run_dbt(["init", project_name, "--skip-profile-setup"])
assert len(manager.mock_calls) == 0
Copy link
Contributor Author

@dbeatty10 dbeatty10 May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed from assert_not_called() to asserting that manager.mock_calls is empty because the former didn't appear to ever fail when I tested it by hand, even when there were calls to the mocks.


with open(os.path.join(project.project_root, project_name, "dbt_project.yml"), "r") as f:
Expand Down Expand Up @@ -706,5 +706,5 @@ def test_init_inside_project_and_skip_profile_setup(
assert Path("dbt_project.yml").exists()

# skip interactive profile setup
run_dbt(["init", "-s"])
run_dbt(["init", "--skip-profile-setup"])
assert len(manager.mock_calls) == 0