Skip to content

Target path should be relative to project dir, rather than current working directory #7706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gshank merged 13 commits into from
May 26, 2023
Merged

Target path should be relative to project dir, rather than current working directory #7706

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6f039a8
Add "project_target_path" property to RuntimeConfig, switch to using it
gshank May 25, 2023
db8cd11
Split up write_node into "node_compiled_path" and "write_node" functions
gshank May 25, 2023
340bb6e
Adjust PreviousState object to use project_root to find "state" and
gshank May 25, 2023
bdc960a
Update code to write out the "run" subdirectory of target
gshank May 25, 2023
a22fb91
tweak project_target_path
gshank May 25, 2023
8a9b67b
Changie
gshank May 25, 2023
7875bb8
fix test_graph_selector_methods.py test
gshank May 25, 2023
a5719ed
Remove chdir that's no longer needed from test
gshank May 26, 2023
e92f3ce
Modify target-path test to run from non-project directory
gshank May 26, 2023
05d298b
Remove resolve_path from state click.Path, modify defer_state test to
gshank May 26, 2023
366a990
use project_root when finding sources.json
gshank May 26, 2023
58ea575
Merge branch 'main' into ct-2491_target_paths
gshank May 26, 2023
51a2ebb
Update to account for defer_state changes
gshank May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove chdir that's no longer needed from test
  • Loading branch information
@gshank
gshank committed May 26, 2023
commit a5719edb679aaa696665ec0a075e3fe22fb1afa8
4 changes: 0 additions & 4 deletions tests/functional/multi_project/test_publication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import json
import pytest
import os

from dbt.tests.util import (
run_dbt,
Expand Down Expand Up @@ -241,8 +240,6 @@ def models_alt(self):

def test_multi_projects(self, project, project_alt):
# run the alternate project by using the alternate project root
# (There is currently a bug where project-dir requires a chdir to work.)
os.chdir(project_alt.project_root)
results, log_output = run_dbt_and_capture(
["--debug", "--log-format=json", "run", "--project-dir", str(project_alt.project_root)]
)
Expand All @@ -255,7 +252,6 @@ def test_multi_projects(self, project, project_alt):
assert len(publication.public_models) == 1

# run the base project
os.chdir(project.project_root)
write_file(dependencies_alt_yml, project.project_root, "dependencies.yml")
results = run_dbt(
["run", "--project-dir", str(project.project_root)], publications=[publication]
Expand Down