Skip to content

fix StopIteration error when publication not found #7710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichelleArk merged 3 commits into from
May 30, 2023
Merged

fix StopIteration error when publication not found #7710

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d8bbc6
fix StopIteration error when publication not found
MichelleArk May 26, 2023
63a6454
changelog entry
MichelleArk May 26, 2023
23974b2
refactor error handling
MichelleArk May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor error handling
  • Loading branch information
@MichelleArk
MichelleArk committed May 30, 2023
commit 23974b2fd852e20c202a37d6927335dff48b7995
18 changes: 10 additions & 8 deletions core/dbt/parser/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,16 +845,18 @@ def build_public_nodes(self) -> bool:

def load_new_public_nodes(self):
for project in self.manifest.project_dependencies.projects:
publication = self.publications.get(project.name)
if publication:
publication_config = PublicationConfig.from_publication(publication)
self.manifest.publications[project.name] = publication_config
# Add to dictionary of public_nodes and save id in PublicationConfig
for public_node in publication.public_models.values():
self.manifest.public_nodes[public_node.unique_id] = public_node
else:
try:
publication = self.publications[project.name]
except KeyError:
raise PublicationConfigNotFound(project=project.name)

publication_config = PublicationConfig.from_publication(publication)
self.manifest.publications[project.name] = publication_config

# Add to dictionary of public_nodes and save id in PublicationConfig
for public_node in publication.public_models.values():
self.manifest.public_nodes[public_node.unique_id] = public_node

def is_partial_parsable(self, manifest: Manifest) -> Tuple[bool, Optional[str]]:
"""Compare the global hashes of the read-in parse results' values to
the known ones, and return if it is ok to re-use the results.
Expand Down