Skip to content

pass optional sql_header to empty subquery sql rendering #7734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichelleArk merged 4 commits into from
Jun 1, 2023
+96 −6
Merged

pass optional sql_header to empty subquery sql rendering #7734

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5c8ad1
pass optional sql_header to empty subquery sql rendering
MichelleArk May 30, 2023
fb8d6b8
add tests
MichelleArk May 31, 2023
d5b4490
changelog entry
MichelleArk May 31, 2023
4ae9583
renaming tests for consistency
MichelleArk May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
renaming tests for consistency
  • Loading branch information
@MichelleArk
MichelleArk committed May 31, 2023
commit 4ae958376b275fc34c6548e1713e67b1c68c3e1b
12 changes: 10 additions & 2 deletions tests/adapter/dbt/tests/adapter/constraints/test_constraints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ def test__contract_sql_header(self, project):
assert model_config.contract.enforced


class TestTableContractSqlHeader(BaseContractSqlHeader):
class BaseTableContractSqlHeader(BaseContractSqlHeader):
@pytest.fixture(scope="class")
def models(self):
return {
Expand All @@ -383,7 +383,7 @@ def models(self):
}


class TestIncrementalContractSqlHeader(BaseContractSqlHeader):
class BaseIncrementalContractSqlHeader(BaseContractSqlHeader):
@pytest.fixture(scope="class")
def models(self):
return {
Expand All @@ -392,6 +392,14 @@ def models(self):
}


class TestTableContractSqlHeader(BaseTableContractSqlHeader):
pass


class TestIncrementalContractSqlHeader(BaseIncrementalContractSqlHeader):
pass


class BaseModelConstraintsRuntimeEnforcement:
"""
These model-level constraints pass muster for dbt's preflight checks. Make sure they're
Expand Down