Skip to content

Fix not equals comparison to be null-safe for adapters/utils tests #7776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbeatty10 merged 7 commits into from
Jun 6, 2023
Merged

Fix not equals comparison to be null-safe for adapters/utils tests #7776

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1a3d98d
Fix names within functional test
dbeatty10 Jun 4, 2023
9b91b7d
Changelog entry
dbeatty10 Jun 4, 2023
617cf1e
Test for implementation of null-safe equals comparison
dbeatty10 Jun 4, 2023
dfd9ce6
Remove duplicated where filter
dbeatty10 Jun 4, 2023
7a1b395
Fix null-safe equals comparison
dbeatty10 Jun 4, 2023
494753c
Fix tests for `concat` and `hash` by using empty strings () instead o…
dbeatty10 Jun 4, 2023
9aca97a
Remove macro namespace interpolation
dbeatty10 Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix null-safe equals comparison
  • Loading branch information
@dbeatty10
dbeatty10 committed Jun 4, 2023
commit 7a1b3959da296725bc3fc7d6ca636d959a8b92ce
6 changes: 3 additions & 3 deletions .changes/unreleased/Features-20230604-080052.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
kind: Features
body: Cross-database null-safe equals comparison via `equals`
kind: Fixes
body: Fix null-safe equals comparison via `equals`
time: 2023-06-04T08:00:52.537967-06:00
custom:
Author: dbeatty10
Issue: "6997"
Issue: "7778"
8 changes: 5 additions & 3 deletions tests/adapter/dbt/tests/adapter/utils/base_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@
from dbt.tests.util import run_dbt

macros__equals_sql = """
{% macro equals(actual, expected) %}
{# -- actual is not distinct from expected #}
(({{ actual }} = {{ expected }}) or ({{ actual }} is null and {{ expected }} is null))
{% macro equals(expr1, expr2) -%}
case when (({{ expr1 }} = {{ expr2 }}) or ({{ expr1 }} is null and {{ expr2 }} is null))
then 0
else 1
end = 0
{% endmacro %}
"""

Expand Down