Skip to content

Allow setting packages in dependencies.yml and move dependencies to runtime config #7857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gshank merged 8 commits into from
Jun 15, 2023
Merged

Allow setting packages in dependencies.yml and move dependencies to runtime config #7857

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f40bd4f
add dependent_projects in lots of places
gshank Jun 9, 2023
bfd3885
Modify code to use RunTimeConfig.dependent_projects
gshank Jun 9, 2023
31aa6b6
remove project_dependencies from manifest
gshank Jun 9, 2023
91246d9
Merge branch 'main' into ct-7631-unified_dependencies
gshank Jun 13, 2023
4c05555
Remove test for project dependencies in manifest. Now untestable.
gshank Jun 13, 2023
4dabf19
Update some tests
gshank Jun 13, 2023
3f37167
Changie
gshank Jun 13, 2023
1682c35
formatting
gshank Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove test for project dependencies in manifest. Now untestable.
  • Loading branch information
@gshank
gshank committed Jun 13, 2023
commit 4c05555cba923437473e2c478a6091f1720e9d22
2 changes: 1 addition & 1 deletion core/dbt/contracts/graph/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
from typing_extensions import Protocol
from uuid import UUID

from dbt.contracts.publication import ProjectDependencies, PublicationConfig, PublicModel
from dbt.contracts.publication import PublicationConfig, PublicModel

from dbt.contracts.graph.nodes import (
BaseNode,
Expand Down
10 changes: 1 addition & 9 deletions tests/functional/multi_project/test_publication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
run_dbt_and_capture,
get_logging_events,
)
from dbt.contracts.publication import ProjectDependency, PublicationArtifact, PublicModel
from dbt.contracts.publication import PublicationArtifact, PublicModel
from dbt.exceptions import (
PublicationConfigNotFound,
TargetNotFoundError,
Expand Down Expand Up @@ -157,14 +157,6 @@ def test_pub_artifacts(self, project):
publication = PublicationArtifact.from_dict(publication_dict)
assert publication.dependencies == ["marketing"]

# check project_dependencies in manifest
project_dependencies = manifest.project_dependencies
assert project_dependencies
project_dependency = project_dependencies.projects[0]
assert isinstance(project_dependency, ProjectDependency)
assert project_dependency.name == "marketing"
assert "custom_field" in project_dependency._extra

# source_node, target_model_name, target_model_package, target_model_version, current_project, node_package
resolved_node = manifest.resolve_ref(None, "fct_one", "marketing", None, "test", "test")
assert resolved_node
Expand Down