Skip to content

Improved Semantic Model Measure Percentile defaults #7877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QMalcolm merged 3 commits into from
Jun 23, 2023
Merged

Improved Semantic Model Measure Percentile defaults #7877

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39eca85
Update semantic model parsing test to check measure agg params
QMalcolm Jun 14, 2023
330877b
Make `use_discrete_percentile` and `use_approximate_percentile` non o…
QMalcolm Jun 14, 2023
2bfea81
Add changie doc for measure percentile fixes
QMalcolm Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update semantic model parsing test to check measure agg params
  • Loading branch information
@QMalcolm
QMalcolm committed Jun 23, 2023
commit 39eca851e5eb638928f7943a6cc6e8e17309b98d
14 changes: 13 additions & 1 deletion tests/functional/semantic_models/test_semantic_model_parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,18 @@
- name: has_revenue
expr: true
agg: sum_boolean
- name: discrete_order_value_p99
expr: order_total
agg: percentile
agg_params:
percentile: 0.99
use_discrete_percentile: True
use_approximate_percentile: False
- name: test_agg_params_optional_are_empty
expr: order_total
agg: percentile
agg_params:
percentile: 0.99

dimensions:
- name: ds
Expand Down Expand Up @@ -71,7 +83,7 @@ def test_semantic_model_parsing(self, project):
semantic_model.node_relation.relation_name
== f'"dbt"."{project.test_schema}"."fct_revenue"'
)
assert len(semantic_model.measures) == 3
assert len(semantic_model.measures) == 5

@pytest.mark.skip("Restore this test when partial parsing is implemented.")
def test_semantic_model_partial_parsing(self, project):
Expand Down