Skip to content

Set access model node args #7966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichelleArk merged 2 commits into from
Jun 27, 2023
Merged

Set access model node args #7966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b7ba3a
add access to ModelNodeArgs for external node construction
MichelleArk Jun 27, 2023
ab94670
changelog entry
MichelleArk Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20230627-152528.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: add access to ModelNodeArgs for external node building
time: 2023-06-27T15:25:28.488767-04:00
custom:
Author: michelleark
Issue: "7890"
2 changes: 2 additions & 0 deletions core/dbt/contracts/graph/node_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from typing import Optional

from dbt.contracts.graph.unparsed import NodeVersion
from dbt.node_types import AccessType


@dataclass
Expand All @@ -16,4 +17,5 @@ class ModelNodeArgs:
version: Optional[NodeVersion] = None
latest_version: Optional[NodeVersion] = None
deprecation_date: Optional[datetime] = None
access: Optional[str] = AccessType.Protected.value
Copy link
Contributor Author

@MichelleArk MichelleArk Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted for a string instead of AccessType to have a simpler interface for the external node construction. Core will still raises an error for an invalid value when it's converted it to an AccessType in ModelNode.from_args

Copy link
Contributor

@gshank gshank Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. We do a similar thing for enums in unparsed classses.

generated_at: datetime = field(default_factory=datetime.utcnow)
1 change: 1 addition & 0 deletions core/dbt/contracts/graph/nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,7 @@ def from_args(cls, args: ModelNodeArgs) -> "ModelNode":
alias=args.identifier,
deprecation_date=args.deprecation_date,
checksum=FileHash.from_contents(f"{unique_id},{args.generated_at}"),
access=AccessType(args.access),
original_file_path="",
path="",
)
Expand Down
1 change: 1 addition & 0 deletions core/dbt/parser/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,6 +776,7 @@ def build_external_nodes(self) -> List[ModelNodeArgs]:
schema=public_node.schema,
identifier=public_node.identifier,
deprecation_date=public_node.deprecation_date,
access=AccessType.Public,
)
)

Expand Down