Skip to content

CT-2707: Populate metric input measures #7984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QMalcolm merged 7 commits into from
Jun 29, 2023
Merged

CT-2707: Populate metric input measures #7984

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a88cd29
Fix tests fixtures which were using measures for metric numerator/den…
QMalcolm Jun 28, 2023
ef6833c
Add tests for ensuring a metric's `input_measures` gets properly popu…
QMalcolm Jun 28, 2023
85f5aa4
Begin populating `metric.type_params.input_measures`
QMalcolm Jun 28, 2023
0104422
Update test checking that disabled metrics aren't added to the manife…
QMalcolm Jun 28, 2023
3c9f336
Update `test_disabled_metric_ref_model` to have more disabled metrics
QMalcolm Jun 28, 2023
2d8445a
Add test which checks that metrics depending on disabled metrics rais…
QMalcolm Jun 28, 2023
c528d91
Add changie doc for populating metric input measures
QMalcolm Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix tests fixtures which were using measures for metric numerator/den… 
…ominators

In our previous upgrade to DSI dev7, numerators and denominators for
metrics switched from being `MetricInputMeasure`s to `MetricInput`s.
I.e. metric numerators and denominators should references other metrics,
not semantic model measures. However, at that time, we weren't actually
doing anything with numerators and denominators in core, so no issue
got raised. The changes we are about to make though are going to surface
these issues..
  • Loading branch information
@QMalcolm
QMalcolm committed Jun 28, 2023
commit a88cd29c70b4915ae26fb548648727a68d03caee
6 changes: 2 additions & 4 deletions tests/functional/metrics/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,8 @@
description: "The average tenure per person"
type: ratio
type_params:
numerator:
name: years_tenure
denominator:
name: people
numerator: collective_tenure
denominator: number_of_people

- name: average_tenure_plus_one
label: "Average tenure, plus 1"
Expand Down