Skip to content

CT-2691 Fix the populating of a Metric's depends_on property #8015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QMalcolm merged 18 commits into from
Jul 12, 2023
+462 −34
Merged

CT-2691 Fix the populating of a Metric's depends_on property #8015

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e3ff212
Add metrics from metric type params to a metric's depends_on
QMalcolm Jun 30, 2023
3812738
Add Lookup utility for finding `SemanticModel`s by measure names
QMalcolm Jul 1, 2023
62b7ce4
Add the `SemanticModel` of a `Metric`'s measure property to the `Metr…
QMalcolm Jul 1, 2023
19ba616
Add `SemanticModelConfig` to `SemanticModel`
QMalcolm Jul 10, 2023
dbe943b
Checkpoint on test fixing
QMalcolm Jul 11, 2023
63a7aca
Correct metricflow_time_spine_sql in test fixtures
QMalcolm Jul 11, 2023
7e1cffa
Add check for `SemanticModel` nodes in `Linker.link_node`
QMalcolm Jul 11, 2023
a064146
Fix artifacts/test_previous_version_state.py tests
gshank Jul 11, 2023
087b627
fix access/test_access.py tests
gshank Jul 11, 2023
1ae9763
Fix function metric tests
QMalcolm Jul 11, 2023
10f1c26
Fix functional partial_parsing tests
QMalcolm Jul 11, 2023
41a52c5
Merge branch 'main' into ct-2691--fix-metric-node-depends-on-population
QMalcolm Jul 11, 2023
fb67d0a
Add time dimension to semantic model in exposures fixture
QMalcolm Jul 12, 2023
ba230f1
Bump DSI version to a minimum of 0.1.0dev10
QMalcolm Jul 12, 2023
d476e54
Add test specifically for checking the `depends_on` of `Metric` nodes
QMalcolm Jul 12, 2023
2caf63d
Re-enable test asserting calling metric nodes in models
QMalcolm Jul 12, 2023
6a0af56
Migrate `checked_agg_time_dimension` to `checked_agg_time_dimension_f…
QMalcolm Jul 12, 2023
0080a21
Add changie doc for populating metric
QMalcolm Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add changie doc for populating metric
  • Loading branch information
@QMalcolm
QMalcolm committed Jul 12, 2023
commit 0080a211ffa83e2b9ca91cc00b46f58c2b2af7ae
6 changes: 6 additions & 0 deletions .changes/unreleased/Features-20230712-123724.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Features
body: Begin populating `depends_on` of metric nodes
time: 2023-07-12T12:37:24.01449-07:00
custom:
Author: QMalcolm gshank
Issue: "7854"