Skip to content

partial parse file path #8032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChenyuLInx merged 4 commits into from
Jul 10, 2023
Merged

partial parse file path #8032

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
623cf56
partial parse file path
ChenyuLInx Jul 5, 2023
c89ad77
add test
ChenyuLInx Jul 7, 2023
373b6f3
add_changelog
ChenyuLInx Jul 7, 2023
12d9541
nits
ChenyuLInx Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
nits
  • Loading branch information
@ChenyuLInx
ChenyuLInx committed Jul 7, 2023
commit 12d95410b776b5c6e681da19d4250ff89a6e61e3
2 changes: 1 addition & 1 deletion core/dbt/parser/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ def read_manifest_for_partial_parse(self) -> Optional[Manifest]:
if not flags.PARTIAL_PARSE:
fire_event(PartialParsingNotEnabled())
return None
path = flags.partial_parse_file_path or os.path.join(
path = flags.PARTIAL_PARSE_FILE_PATH or os.path.join(
self.root_project.project_target_path, PARTIAL_PARSE_FILE_NAME
)

Expand Down
8 changes: 5 additions & 3 deletions tests/unit/test_parse_manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,16 @@ def _new_file(self, searched, name, match):
class TestPartialParse(unittest.TestCase):
@patch("dbt.parser.manifest.ManifestLoader.build_manifest_state_check")
@patch("dbt.parser.manifest.os.path.exists")
def test_partial_parse_file_path(self, patched_os_exist, patched_state_check):
@patch("dbt.parser.manifest.open")
def test_partial_parse_file_path(self, patched_open, patched_os_exist, patched_state_check):
mock_project = MagicMock(RuntimeConfig)
mock_project.project_target_path = "mock_target_path"
patched_os_exist.return_value = True
set_from_args(Namespace(), {})
ManifestLoader(mock_project, {})
# by default we use the project_target_path
patched_os_exist.assert_called_with("mock_target_path/partial_parse.msgpack")
patched_open.assert_called_with("mock_target_path/partial_parse.msgpack", "rb")
set_from_args(Namespace(partial_parse_file_path="specified_partial_parse_path"), {})
ManifestLoader(mock_project, {})
# if specified in flags, we use the specified path
patched_os_exist.assert_called_with("specified_partial_parse_path")
patched_open.assert_called_with("specified_partial_parse_path", "rb")