Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20230705-192039.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: include 'v' in ModelNodeArgs.unique_id
time: 2023-07-05T19:20:39.581291-04:00
custom:
Author: michelleark
Issue: "8039"
2 changes: 1 addition & 1 deletion core/dbt/contracts/graph/node_args.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ class ModelNodeArgs:
def unique_id(self) -> str:
unique_id = f"{NodeType.Model}.{self.package_name}.{self.name}"
if self.version:
unique_id = f"{unique_id}.{self.version}"
unique_id = f"{unique_id}.v{self.version}"

return unique_id
19 changes: 19 additions & 0 deletions tests/unit/test_contracts_graph_node_args.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
from dbt.contracts.graph.node_args import ModelNodeArgs


class TestModelNodeArgs:
def test_model_node_args_unique_id(self) -> None:
model_node_args = ModelNodeArgs(
name="name", package_name="package", identifier="identifier", schema="schema"
)
assert model_node_args.unique_id == "model.package.name"

def test_model_node_args_unique_id_with_version(self) -> None:
model_node_args = ModelNodeArgs(
name="name",
package_name="package",
identifier="identifier",
schema="schema",
version="1",
)
assert model_node_args.unique_id == "model.package.name.v1"