Skip to content

Semantic Model Validation #8049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterallenwebb merged 6 commits into from
Jul 10, 2023
Merged

Semantic Model Validation #8049

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2125bb2
Use dbt-semantic-interface validations on semantic models and metrics…
peterallenwebb Jul 7, 2023
fd33b52
Remove empty test, since semantic models don't generate any validatio…
peterallenwebb Jul 7, 2023
3699dfa
Merge remote-tracking branch 'origin/main' into paw/semantic-model-va…
peterallenwebb Jul 7, 2023
ea3f6ff
Add changelog entry.
peterallenwebb Jul 7, 2023
3328806
Merge remote-tracking branch 'origin/main' into paw/semantic-model-va…
peterallenwebb Jul 7, 2023
1b09d68
Temporarily remove requirement that there must be semantic models def…
peterallenwebb Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Temporarily remove requirement that there must be semantic models def… 
…inied in order to define metrics
  • Loading branch information
@peterallenwebb
peterallenwebb committed Jul 10, 2023
commit 1b09d68084ce126acafa35bb68a772afb1ef04ba
17 changes: 9 additions & 8 deletions core/dbt/contracts/graph/semantic_manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,15 @@ def __init__(self, manifest):

def validate(self) -> bool:

if self.manifest.metrics and not self.manifest.semantic_models:
fire_event(
SemanticValidationFailure(
msg="Metrics require semantic models, but none were found."
),
EventLevel.ERROR,
)
return False
# TODO: Enforce this check.
# if self.manifest.metrics and not self.manifest.semantic_models:
# fire_event(
# SemanticValidationFailure(
# msg="Metrics require semantic models, but none were found."
# ),
# EventLevel.ERROR,
# )
# return False

if not self.manifest.metrics or not self.manifest.semantic_models:
return True
Expand Down