Skip to content

[CT-2840] Improved semantic layer protocol satisfaction tests #8456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QMalcolm merged 12 commits into from
Aug 29, 2023
Merged

[CT-2840] Improved semantic layer protocol satisfaction tests #8456

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7cbf8ae
Test `SemanticModel` satisfies protocol when none of it's `Optionals`…
QMalcolm Aug 16, 2023
b1a0c9d
Add tests ensuring SourceFileMetadata and FileSlice satisfiy DSI prot…
QMalcolm Aug 16, 2023
9167e38
Add test asserting Defaults obj satisfies protocol
QMalcolm Aug 16, 2023
cab3800
Add test asserting SemanticModel with optionals specified satisfies p…
QMalcolm Aug 16, 2023
c797c29
Split dimension protocol satisfaction tests into with and without opt…
QMalcolm Aug 16, 2023
b57d361
Simplify DSI Protocol import strategy in protocol satisfaction tests
QMalcolm Aug 16, 2023
6b961c7
Add test asserting DimensionValidtyParams satisfies protocol
QMalcolm Aug 16, 2023
5db6a32
Add test asserting DimensionTypeParams satisfies protocol
QMalcolm Aug 16, 2023
3af7881
Split entity protocol satisfaction tests into with and without optionals
QMalcolm Aug 16, 2023
8c3291b
Split measure protocol satisfication tests and add measure aggregatio…
QMalcolm Aug 16, 2023
45bb03c
Split metric protocol satisfaction test into optional specified an un…
QMalcolm Aug 17, 2023
75856e5
Improve protocol satisfaction tests for MetricTypeParams and sub prot…
QMalcolm Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test asserting DimensionTypeParams satisfies protocol
  • Loading branch information
@QMalcolm
QMalcolm committed Aug 16, 2023
commit 5db6a328fa580d39b3e234cedf085f7a780d16cb
32 changes: 27 additions & 5 deletions tests/unit/test_semantic_layer_nodes_satisfy_protocols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import pytest
import copy

from dbt.contracts.graph.nodes import (
Metric,
Expand Down Expand Up @@ -116,6 +117,11 @@ class RuntimeCheckableDimensionValidityParams(
pass


@runtime_checkable
class RuntimeCheckableDimensionTypeParams(DimensionProtocols.DimensionTypeParams, Protocol):
pass


@pytest.fixture(scope="session")
def file_slice() -> FileSlice:
return FileSlice(
Expand All @@ -141,6 +147,11 @@ def dimension_validity_params() -> DimensionValidityParams:
return DimensionValidityParams()


@pytest.fixture(scope="session")
def dimension_type_params() -> DimensionTypeParams:
return DimensionTypeParams(time_granularity=TimeGranularity.DAY)


def test_file_slice_obj_satisfies_protocol(file_slice):
assert isinstance(file_slice, RuntimeCheckableFileSlice)

Expand All @@ -154,10 +165,21 @@ def test_defaults_obj_satisfies_protocol(semantic_model_defaults):
assert isinstance(Defaults(), RuntimeCheckableSemanticModelDefaults)


def test_dimension_validity_params_satisfies_protocl(dimension_validity_params):
def test_dimension_validity_params_satisfies_protocol(dimension_validity_params):
assert isinstance(dimension_validity_params, RuntimeCheckableDimensionValidityParams)


def test_dimension_type_params_satisfies_protocol(
dimension_type_params, dimension_validity_params
):
assert isinstance(dimension_type_params, RuntimeCheckableDimensionTypeParams)

# check with validity params specified
optionals_specified_type_params = copy.deepcopy(dimension_type_params)
optionals_specified_type_params.validity_params = dimension_validity_params
assert isinstance(optionals_specified_type_params, RuntimeCheckableDimensionTypeParams)


def test_semantic_model_node_satisfies_protocol_optionals_unspecified():
test_semantic_model = SemanticModel(
name="test_semantic_model",
Expand Down Expand Up @@ -211,14 +233,14 @@ def test_dimension_satisfies_protocol_optionals_unspecified():
assert isinstance(dimension, RuntimeCheckableDimension)


def test_dimension_satisfies_protocol_optionals_specified(source_file_metadata):
def test_dimension_satisfies_protocol_optionals_specified(
dimension_type_params, source_file_metadata
):
dimension = Dimension(
name="test_dimension",
type=DimensionType.TIME,
description="test_description",
type_params=DimensionTypeParams(
time_granularity=TimeGranularity.DAY,
),
type_params=dimension_type_params,
expr="1",
metadata=source_file_metadata,
)
Expand Down