Skip to content

update the implementation template #8466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emmyoop merged 2 commits into from
Aug 22, 2023
Merged

update the implementation template #8466

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1e0496
update the implementation template
emmyoop Aug 21, 2023
f922615
add colon
emmyoop Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions .github/ISSUE_TEMPLATE/implementation-ticket.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: 🛠️ Implementation
description: This is an implementation ticket intended for use by the maintainers of dbt-core
title: "[<project>] <title>"
labels: ["user_docs"]
labels: ["user docs"]
body:
- type: markdown
attributes:
Expand All @@ -11,7 +11,7 @@ body:
label: Housekeeping
description: >
A couple friendly reminders:
1. Remove the `user_docs` label if the scope of this work does not require changes to https://docs.getdbt.com/docs: no end-user interface (e.g. yml spec, CLI, error messages, etc) or functional changes
1. Remove the `user docs` label if the scope of this work does not require changes to https://docs.getdbt.com/docs: no end-user interface (e.g. yml spec, CLI, error messages, etc) or functional changes
2. Link any blocking issues in the "Blocked on" field under the "Core devs & maintainers" project.
options:
- label: I am a maintainer of dbt-core
Expand All @@ -32,9 +32,20 @@ body:
required: true
- type: textarea
attributes:
label: Impact to Adapters
label: Impact to Other Teams
description: |
Will this require changes to adapter repos? Include details of the kinds of changes required (new tests, code changes, related tickets)
Will this change impact other teams? Include details of the kinds of changes required (new tests, code changes, related tickets) and _add the relevant `Impact[team]` label_.
Copy link

@martynydbt martynydbt Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit if worth changing Impact:[team] there's a colon in the naming convention

placeholder: |
Example: This change impacts `dbt-redshift` because the tests will need to be modified. The `Impact[Adapter]` label has been added.
Copy link

@martynydbt martynydbt Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here w colon if worth it

validations:
required: true
- type: textarea
attributes:
label: Will backports be required?
description: |
Will this change need to be backported to previous versions? Add details, possible blockers to backporting and _add the relevant backport labels `backport 1.x.latest`_
placeholder: |
Example: Backport to 1.6.latest, 1.5.latest and 1.4.latest. Since 1.4 isn't using click, the backport may be complicated. The `backport 1.6.latest`, `backport 1.5.latest` and `backport 1.4.latest` labels have been added.
validations:
required: true
- type: textarea
Expand Down