Skip to content

Fix ambiguous reference error for duplicate model names across packages with tests #8488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichelleArk merged 6 commits into from
Aug 25, 2023
Merged

Fix ambiguous reference error for duplicate model names across packages with tests #8488

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e6dfde
pass package_name to ref lookup for attached_node
MichelleArk Aug 24, 2023
00cb808
add functional test: TestDuplicateModelNameWithTestAcrossPackages
MichelleArk Aug 24, 2023
543aad7
changelog entry
MichelleArk Aug 24, 2023
9c98347
pass package_name when looking up versioned model node during parsing
MichelleArk Aug 24, 2023
f170ea0
fix unit tests
MichelleArk Aug 24, 2023
2bb22ca
changelog entry
MichelleArk Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
pass package_name to ref lookup for attached_node
  • Loading branch information
@MichelleArk
MichelleArk committed Aug 24, 2023
commit 9e6dfdee68da9a3c9c77fc19198c98de2cbb08b4
2 changes: 1 addition & 1 deletion core/dbt/parser/schema_generic_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def _lookup_attached_node(
attached_node = None # type: Optional[Union[ManifestNode, GraphMemberNode]]
if not isinstance(target, UnpatchedSourceDefinition):
attached_node_unique_id = self.manifest.ref_lookup.get_unique_id(
target.name, None, version
target.name, target.package_name, version
)
if attached_node_unique_id:
attached_node = self.manifest.nodes[attached_node_unique_id]
Expand Down