Include Compiled Node Attributes in run_results.json #8492

peterallenwebb · 2023-08-24T21:09:44Z

resolves #7519

Problem

Solution

Checklist

I have read the contributing guide and understand what's expected of me
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

codecov · 2023-08-24T21:12:48Z

Codecov Report

Patch coverage: 92.30% and project coverage change: -0.01% ⚠️

Comparison is base (f063e4e) 86.34% compared to head (bda7219) 86.34%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8492      +/-   ##
==========================================
- Coverage   86.34%   86.34%   -0.01%     
==========================================
  Files         174      174              
  Lines       25531    25541      +10     
==========================================
+ Hits        22046    22054       +8     
- Misses       3485     3487       +2

Flag	Coverage Δ
integration	`83.14% <92.30%> (-0.01%)`	⬇️
unit	`65.09% <53.84%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
core/dbt/tests/util.py	`86.50% <85.71%> (-0.07%)`	⬇️
core/dbt/contracts/results.py	`97.80% <100.00%> (+0.03%)`	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gshank

tests/functional/invariants/invariants.py is kind of odd naming. Why "invariants"? Why the doubled up name? Is there some reason you put "get_run_results" in that file instead of in dbt/tests/util.py along with "get_manifest"?

Looks like artifacts tests need to be fixed...

peterallenwebb · 2023-08-29T20:16:41Z

tests/functional/invariants/invariants.py is kind of odd naming. Why "invariants"? Why the doubled up name?

@gshank I agree this was awkwardly named. The conditions I wound up calling "assertions" were initially "invariants" for nerdy reasons, but I thought calling them assertions was more friendly, and I should have made the naming consistent.

Let me know what you think of the new names I chose.

Is there some reason you put "get_run_results" in that file instead of in dbt/tests/util.py along with "get_manifest"?

Only that it didn't occur to me. I've moved the code to tests/util.py.

Looks like artifacts tests need to be fixed...

Fixed!

* revert python version for docker images * add comment to not update python version, update changelog

* Update semantic model parsing tests to check measure non_additive_dimension spec * Make `window_groupings` default to empty list if not specified on `non_additive_dimension` * Add changie doc for `window_groupings` parsing fix

* add show test for json data * oh changie my changie * revert unecessary cahnge to fixture * keep decimal class for precision methods, but return __int__ value * jerco updates * update integer type * update other tests * Update .changes/unreleased/Fixes-20230803-093502.yaml --------- Co-authored-by: Emily Rockman <[email protected]>

* Improve docker image README - Fix unnecessary/missing newline escapes - Remove double whitespace between parameters - 2-space indent for extra lines in image build commands * Add changelog entry for #8212

* apply reformatting changes only for #8449 * add logging back to get_create_materialized_view_as_sql * changie

* update the implementation template * add colon

* add flaky decorator * split up tests into classes

…, fix msg format (#8451) * first pass, tests need updates * update proto defn * fixing tests * more test fixes * finish fixing test file * reformat the message * formatting messages * changelog * add event to unit test * feedback on message structure * WIP * fix up event to take in all fields * fix test

…es with tests (#8488)

* Test `SemanticModel` satisfies protocol when none of it's `Optionals` are specified * Add tests ensuring SourceFileMetadata and FileSlice satisfiy DSI protocols * Add test asserting Defaults obj satisfies protocol * Add test asserting SemanticModel with optionals specified satisfies protocol * Split dimension protocol satisfaction tests into with and without optionals * Simplify DSI Protocol import strategy in protocol satisfaction tests * Add test asserting DimensionValidtyParams satisfies protocol * Add test asserting DimensionTypeParams satisfies protocol * Split entity protocol satisfaction tests into with and without optionals * Split measure protocol satisfication tests and add measure aggregation params satisficaition test * Split metric protocol satisfaction test into optional specified an unspecified Additionally, create where_filter pytest fixture * Improve protocol satisfaction tests for MetricTypeParams and sub protocols Specifically we added/improved protocol satisfaction tests for - MetricTypeParams - MetricInput - MetricInputMeasure - MetricTimeWindow

)

…un-results

gshank

Looks good!

FishtownBuildBot · 2023-09-25T20:07:01Z

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4125

peterallenwebb added 2 commits August 21, 2023 10:38

Add compiled node properties to run_results.json

6448cc1

Include compiled-node attributes in run_results.json

516f50f

cla-bot bot added the cla:yes label Aug 24, 2023

peterallenwebb added 2 commits August 25, 2023 16:43

Fix typo

1afd3aa

Bump schema version of run_results

fd510e4

peterallenwebb marked this pull request as ready for review August 29, 2023 14:04

peterallenwebb requested review from a team as code owners August 29, 2023 14:04

peterallenwebb requested review from martynydbt and vadim82 and removed request for a team August 29, 2023 14:04

Fix test assertions

8f69ca7

gshank reviewed Aug 29, 2023

View reviewed changes

peterallenwebb added 2 commits August 29, 2023 13:09

Update expected run_results to reflect new attributes

9736a89

Code review changes

57808b4

gshank and others added 13 commits August 30, 2023 14:49

Fix mypy warnings for ManifestLoader.load() (#8443)

59012dd

revert python version for docker images (#8445)

79f6dc8

* revert python version for docker images * add comment to not update python version, update changelog

Bumping version to 1.7.0b1 and generate changelog

debfb3c

[CT-3013] Fix parsing of window_groupings (#8454)

3769acd

* Update semantic model parsing tests to check measure non_additive_dimension spec * Make `window_groupings` default to empty list if not specified on `non_additive_dimension` * Add changie doc for `window_groupings` parsing fix

Improve docker image README (#8212)

45c8d6d

* Improve docker image README - Fix unnecessary/missing newline escapes - Remove double whitespace between parameters - 2-space indent for extra lines in image build commands * Add changelog entry for #8212

ADAP-814: Refactor prep for MV updates (#8459)

7bb45d5

* apply reformatting changes only for #8449 * add logging back to get_create_materialized_view_as_sql * changie

swap trigger (#8463)

1313739

update the implementation template (#8466)

9b02109

* update the implementation template * add colon

Split tests into classes (#8474)

9f64fa8

* add flaky decorator * split up tests into classes

revert update agate for int (#8478)

1aff3b4

updated typing and methods to meet mypy standards (#8485)

a890087

MichelleArk and others added 6 commits August 30, 2023 14:49

Fix ambiguous reference error for duplicate model names across packag…

49e1843

…es with tests (#8488)

Safely remove external nodes from manifest (#8495)

a51f383

Convert to using mashumaro jsonschema with acceptable performance (#8437

9097548

)

Merge remote-tracking branch 'origin/main' into paw/copiled-code-in-r…

8f4b440

…un-results

Regenerate run_results schema after merging in changes from main.

bda7219

gshank approved these changes Aug 30, 2023

View reviewed changes

peterallenwebb closed this Aug 30, 2023

peterallenwebb reopened this Aug 30, 2023

peterallenwebb merged commit fc1a14a into main Aug 30, 2023

peterallenwebb deleted the paw/copiled-code-in-run-results branch August 30, 2023 21:28

graciegoheen added the user docs [docs.getdbt.com] Needs better documentation label Sep 25, 2023

dbeatty10 mentioned this pull request Oct 12, 2023

update run results docs to include compiled node attributes from dbt-core PR #8492 dbt-labs/docs.getdbt.com#4125

Closed

tlento mentioned this pull request Nov 6, 2023

Update typing-extensions version to >=4.4 #9012

Merged

5 tasks

tlento mentioned this pull request Feb 26, 2024

Update dbt-semantic-interfaces dependency to compatible range #9671

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Include Compiled Node Attributes in run_results.json #8492

Include Compiled Node Attributes in run_results.json #8492

Uh oh!

peterallenwebb commented Aug 24, 2023

Uh oh!

codecov bot commented Aug 24, 2023 •

edited

Loading

Uh oh!

gshank left a comment

Uh oh!

peterallenwebb commented Aug 29, 2023

Uh oh!

gshank left a comment

Uh oh!

FishtownBuildBot commented Sep 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Include Compiled Node Attributes in run_results.json #8492

Include Compiled Node Attributes in run_results.json #8492

Uh oh!

Conversation

peterallenwebb commented Aug 24, 2023

Problem

Solution

Checklist

Uh oh!

codecov bot commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gshank left a comment

Choose a reason for hiding this comment

Uh oh!

peterallenwebb commented Aug 29, 2023

Uh oh!

gshank left a comment

Choose a reason for hiding this comment

Uh oh!

FishtownBuildBot commented Sep 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

codecov bot commented Aug 24, 2023 •

edited

Loading