Skip to content

Conversation

@emmyoop
Copy link
Member

@emmyoop emmyoop commented Aug 31, 2023

resolves #8438
[doc] TBD

Problem

Need ability to add arbitrary configs to dbt_project.yml.

Solution

Add dbt-cloud config to dbt_project.yml.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.02% 🎉

Comparison is base (7ae3de1) 86.36% compared to head (6aa34fe) 86.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8527      +/-   ##
==========================================
+ Coverage   86.36%   86.39%   +0.02%     
==========================================
  Files         174      174              
  Lines       25579    25584       +5     
==========================================
+ Hits        22092    22103      +11     
+ Misses       3487     3481       -6     
Flag Coverage Δ
integration 83.20% <80.00%> (+0.03%) ⬆️
unit 65.03% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/config/runtime.py 96.23% <ø> (ø)
core/dbt/contracts/project.py 97.17% <66.66%> (-0.53%) ⬇️
core/dbt/config/project.py 97.39% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop changed the title first pass at adding dbt-cloud config Support dict dbt-cloud config dict in dbt_project.yml Aug 31, 2023
@emmyoop emmyoop changed the title Support dict dbt-cloud config dict in dbt_project.yml Suppor dbt-cloud config dict in dbt_project.yml Aug 31, 2023
@emmyoop emmyoop changed the title Suppor dbt-cloud config dict in dbt_project.yml Support dbt-cloud config dict in dbt_project.yml Aug 31, 2023
@emmyoop emmyoop marked this pull request as ready for review August 31, 2023 17:53
@emmyoop emmyoop requested a review from a team as a code owner August 31, 2023 17:53
@emmyoop emmyoop requested review from QMalcolm and gshank August 31, 2023 17:53
@emmyoop emmyoop merged commit a0e1356 into main Sep 5, 2023
@emmyoop emmyoop deleted the er/8438-additional-configs branch September 5, 2023 14:48
@emmyoop emmyoop added the user docs [docs.getdbt.com] Needs better documentation label Sep 5, 2023
@FishtownBuildBot
Copy link
Collaborator

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4014

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-8527-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a0e13561b1e92e46559d68cbea469fb1923b8240
# Push it to GitHub
git push --set-upstream origin backport-8527-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-8527-to-1.6.latest.

@emmyoop emmyoop added backport 1.5.latest and removed user docs [docs.getdbt.com] Needs better documentation labels Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-8527-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a0e13561b1e92e46559d68cbea469fb1923b8240
# Push it to GitHub
git push --set-upstream origin backport-8527-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-8527-to-1.5.latest.

emmyoop added a commit that referenced this pull request Sep 5, 2023
* first pass at adding dbt-cloud config

* changelog

* fix test, add direct validation
emmyoop added a commit that referenced this pull request Sep 5, 2023
* first pass at adding dbt-cloud config

* changelog

* fix test, add direct validation
emmyoop added a commit that referenced this pull request Sep 5, 2023
* first pass at adding dbt-cloud config

* changelog

* fix test, add direct validation
@emmyoop emmyoop added the user docs [docs.getdbt.com] Needs better documentation label Sep 5, 2023
emmyoop added a commit that referenced this pull request Sep 5, 2023
* first pass at adding dbt-cloud config

* changelog

* fix test, add direct validation
@emmyoop emmyoop added user docs [docs.getdbt.com] Needs better documentation and removed user docs [docs.getdbt.com] Needs better documentation labels Sep 5, 2023
@emmyoop emmyoop added user docs [docs.getdbt.com] Needs better documentation and removed user docs [docs.getdbt.com] Needs better documentation labels Sep 5, 2023
@dbt-labs dbt-labs deleted a comment from FishtownBuildBot Sep 6, 2023
@dbt-labs dbt-labs deleted a comment from FishtownBuildBot Sep 6, 2023
@dbt-labs dbt-labs deleted a comment from FishtownBuildBot Sep 6, 2023
@dbt-labs dbt-labs deleted a comment from FishtownBuildBot Sep 6, 2023
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes user docs [docs.getdbt.com] Needs better documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CT-3005] Support dictionary of additional configs in dbt_project.yml

4 participants