Don't recurse on over depends_on for non-derived metrics in `revers…

…e_dag_parsing`

The function `reverse_dag_parsing` only cares about derived metrics,
that is metrics that depend on other metrics. Metrics only depend on
other metrics if they are one of the `DERIVED_METRICS` types. Thus
doing a recursive call to `reverse_dag_parsing` for non `DERIVED_METRICS`
types is unnecessary. Previously we were iterating over a metric's
`depends_on` property regardless of whether the metric was a `DERIVED_METRICS`
type. Now we only do this work if the metric is of a `DERIVED_METRICS`
type.

core/dbt/contracts/graph/metrics.py

@@ -66,12 +66,11 @@ def reverse_dag_parsing(
         """
         if metric_node.type in DERIVED_METRICS:
             yield {metric_node.name: metric_depth_count}
-            metric_depth_count = metric_depth_count + 1
 
-        for parent_unique_id in metric_node.depends_on.nodes:
-            metric = manifest.metrics.get(parent_unique_id)
-            if metric is not None and metric.type in DERIVED_METRICS:
-                yield from cls.reverse_dag_parsing(metric, manifest, metric_depth_count)
+            for parent_unique_id in metric_node.depends_on.nodes:
+                metric = manifest.metrics.get(parent_unique_id)
+                if metric is not None:
+                    yield from cls.reverse_dag_parsing(metric, manifest, metric_depth_count + 1)
 
     def full_metric_dependency(self):
         """Returns a unique list of all upstream metric names."""