Skip to content

Conversation

@emmyoop
Copy link
Member

@emmyoop emmyoop commented Sep 11, 2023

resolves #

Problem

The PR template had extra spaces after the resolves # that had to be manually every time a PR got opened.
The PR template required a docs url but we now have automation to generate the docs issues via a label.

Solution

Fix formatting
Update comment and remove docs url

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Sep 11, 2023
@emmyoop emmyoop requested a review from a team as a code owner September 11, 2023 14:22
@emmyoop emmyoop requested review from VersusFacit and aranke and removed request for a team September 11, 2023 14:22
@cla-bot cla-bot bot added the cla:yes label Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (b39eeb3) 86.61% compared to head (032b3d9) 86.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8613      +/-   ##
==========================================
- Coverage   86.61%   86.56%   -0.06%     
==========================================
  Files         174      174              
  Lines       25590    25590              
==========================================
- Hits        22164    22151      -13     
- Misses       3426     3439      +13     
Flag Coverage Δ
integration 83.35% <ø> (-0.13%) ⬇️
unit 65.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop requested a review from dbeatty10 September 11, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes Skip Changelog Skips GHA to check for changelog file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants