Conversation
Contributor
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
emmyoop
commented
Feb 28, 2023
Comment on lines
+98
to
+99
| on: 'icn-filter', | ||
| off: 'icn-filter' |
Member
Author
There was a problem hiding this comment.
Using the same values here means they just won't change when the group is expanded. There was no preexisting icn-filter-on. This bring the most value for now.
stu-k
reviewed
Feb 28, 2023
stu-k
reviewed
Feb 28, 2023
| }) | ||
| }); | ||
|
|
||
| var groups = _.sortBy(_.values(groups), 'name'); |
Contributor
There was a problem hiding this comment.
Since groups is an object, sorting it seems a bit odd since objects are likened to dicts in python. If you wanted a sorted list of keys from groups, I'd do something like Object.keys(groups).sort() then use this sorted array of keys to access groups.
Member
Author
There was a problem hiding this comment.
This sorts the groups by the name value.
stu-k
reviewed
Feb 28, 2023
emmyoop
force-pushed
the
er/ct-2202-group-view
branch
from
66dfcac to
191c3e4
Compare
stu-k
approved these changes
Feb 28, 2023
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #379
Description
Adds a new tab to the left nav that lists the public models by group.
Note: I also removed some console logging to reduce the noise.
Checklist
changie newto create a changelog entry