CT-2103: Implement data_type_code_to_name for redshift #346
Conversation
Co-authored-by: Jeremy Cohen <[email protected]>
|
Looks like this requires a type update: |
|
@colin-rogers-dbt I've fixed it up. It appears the mypy check in CI is more thorough than the local check. |
setup.py
Outdated
| install_requires=[ | ||
| f"dbt-core~={_core_version()}", | ||
| f"dbt-postgres~={_core_version()}", | ||
| "dbt-core~=1.5.0a1", |
There was a problem hiding this comment.
is this intentional?
There was a problem hiding this comment.
It is, and we don't intend to merge this PR as-is. All of the changes to dev-requirements.txt will be reverted before merge.
The problem is that the changeset in dbt-core which this PR coordinates with is branched from dbt-core 1.5.0a1, and I don't know if there is a better way to get the dependencies to work out so that tests pass in CI while cross-repo work is in progress. I don't know what final merge strategy is going to be, but as lead on this, @MichelleArk could provide more detail.
There was a problem hiding this comment.
Final merge strategy will be to merge the core changes first, revert any changes made in adapter branches to for testing (e.g. dev-requirements.txt, setup.py changes), run CI against the latest main branch of core on adapter PRs, and merge on green.
| return "INTEGER_ARRAY" | ||
|
|
||
| @pytest.fixture | ||
| def string_array_type(self): |
There was a problem hiding this comment.
this fixture and the int_array_type one shouldn't be necessary anymore! BaseConstraintsColumnsEqual doesn't do anything with them.
MichelleArk
left a comment
MichelleArk
left a comment
There was a problem hiding this comment.
one small comment on tests, otherwise LGTM!
* CT-2103: Implement data_type_code_to_name for redshift * CT-2103: Hardcode dbt version for testing. * CT-2103: Update dev-requirements to use branch name Co-authored-by: Jeremy Cohen <[email protected]> * CT-2103: Fix mypy complaint * CT-2103: Provide a Redshift specific override of test cases for new tests * CT-2103: Remove now-unneeded fixture overrides * CT-2103: Remove temporary branch hacks in dev-requirements.txt * CT-2103: Revert temporary branch changes to setup.py --------- Co-authored-by: Jeremy Cohen <[email protected]> Co-authored-by: colin-rogers-dbt <[email protected]> Co-authored-by: Mike Alfare <[email protected]>
resolves #319
Description
Implements RedshiftConnectionManager.data_type_code_to_name() in order to support contract validation.
Checklist
changie newto create a changelog entry