This repository was archived by the owner on Sep 2, 2025. It is now read-only.
[Bug] Initialize sqlparse lexer prior to using sqlparse #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikealfare
changed the title
QMalcolm
approved these changes
Feb 6, 2024
Contributor
QMalcolm
left a comment
QMalcolm
left a comment
There was a problem hiding this comment.
Looks great! Thank you for doing this ❤️
colin-rogers-dbt
approved these changes
Feb 6, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* changelog * initialize sqlparse Lexer prior to using sqlparse (cherry picked from commit d9274de)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* changelog * initialize sqlparse Lexer prior to using sqlparse (cherry picked from commit d9274de)
This was referenced Feb 6, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* changelog * initialize sqlparse Lexer prior to using sqlparse (cherry picked from commit d9274de)
mikealfare
added a commit
that referenced
this pull request
Feb 6, 2024
* changelog * initialize sqlparse Lexer prior to using sqlparse (cherry picked from commit d9274de) Co-authored-by: Mike Alfare <[email protected]>
mikealfare
added a commit
that referenced
this pull request
Feb 6, 2024
* changelog * initialize sqlparse Lexer prior to using sqlparse (cherry picked from commit d9274de) Co-authored-by: Mike Alfare <[email protected]>
mikealfare
added a commit
that referenced
this pull request
Feb 6, 2024
* changelog * initialize sqlparse Lexer prior to using sqlparse (cherry picked from commit d9274de) Co-authored-by: Mike Alfare <[email protected]>
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #710
Problem
We are seeing an error when running
dbt docs generateon a set of sources that uses external tables. This error is similar to what we saw here: dbt-labs/dbt-core#8217.Solution
We need to initialize
Lexerinsqlparseprior to usingsqlparse, as is done in this PR: dbt-labs/dbt-core#8215Checklist