Fix minor issues with semantic model defaults validation #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
The validation hook associated with SemanticModelDefaults would register an error state if the optional agg_time_dimension property was not set. There was also a stray classmethod that really ought to be a staticmethod. Forgive the "while I'm here" fixing but it doesn't seem worth a separate commit.
tlento
force-pushed
the
cleanup-validator-things
branch
from
cb4ba18 to
78276af
Compare
QMalcolm
approved these changes
Jun 30, 2023
Collaborator
QMalcolm
left a comment
QMalcolm
left a comment
There was a problem hiding this comment.
Ahh I see what was happening. The validation assumed that if defaults was specified, an agg time dim was required, when it's not. The change makes complete sense. Thank you for catching this and fixing it!
WilliamDee
approved these changes
Jun 30, 2023
This was referenced Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation hook associated with SemanticModelDefaults would
register an error state if the optional agg_time_dimension property
was not set.
There was also a stray classmethod that really ought to be a staticmethod.
Forgive the "while I'm here" fixing but it doesn't seem worth a separate
commit.