Update documentation on yml version defaults#5672
Merged
mirnawong1 merged 3 commits intodbt-labs:currentfrom Jun 19, 2024
Merged
Update documentation on yml version defaults#5672mirnawong1 merged 3 commits intodbt-labs:currentfrom
mirnawong1 merged 3 commits intodbt-labs:currentfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
Contributor
Author
|
I assume the PRs that are failing are to do with managing PRs, not to functionality. Please let me know if any actions are required from me. |
mirnawong1
approved these changes
Jun 19, 2024
Contributor
mirnawong1
left a comment
mirnawong1
left a comment
There was a problem hiding this comment.
hey @LeoTheGriff , great catch! you're absolutely right and i like your re-wording! will get this merged for you - looking forward to your future contributions ✨ many thanks for opening this up :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
The config-version documentation is not clear about what the default value is. It states that the parameter is optional and that the old version, version 1, is not in use. This implies that the default version should be 2, but the default is explicitly stated here as version 1.
## Default Without this configuration, dbt will assume your dbt_project.yml uses the version 1 syntax, which was deprecated in dbt v0.19.0.As per PR dbt-labs/dbt-core#7060, the default version is in-fact version 2, so this documentation needs to be updated.
Checklist