Use Queue API instead of inefficient operations #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Scala 2.10.x, Queue#:+ has a performance issue. scala/scala@f0f0a5e So this commit replaces that operations with Queue#enqueue. And use Queue#dequeue explicitly instead of Queue#head and Queue#tail. There is little dirrerence between these operations, but it will be obvious that Queue is used correctly.
Contributor
Author
|
When I tried to request too many commands, Queue#:+ in ResponseHandling spent much time. |
Owner
|
Thanks .. I will take a look and merge ASAP. |
Contributor
Author
|
I found another bottleneck……, so I'm going to fix that. |
okumin
force-pushed
the
replace-queue-operation
branch
from
c9c3935 to
70761cc
Compare
Contributor
Author
|
It is difficult to fix, so created the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Scala 2.10.x, Queue#:+ has a performance issue.
scala/scala@f0f0a5e
So this commit replaces that operations with Queue#enqueue.
And use Queue#dequeue explicitly instead of Queue#head and Queue#tail. There is little dirrerence between these operations, but it will be obvious that Queue is used correctly.