Skip to content

Stop using ExecutionContext.global and receive ExecutionContext by the implicit parameter #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okumin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stop using ExecutionContext.global and receive ExecutionContext by the implicit parameter #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Stop using ExecutionContext.global and receive ExecutionContext by th… 
…e implicit parameter

I think that ExecutionContext should be chosen by users.
  • Loading branch information
@okumin
okumin committed Sep 20, 2014
commit c85228767348ea18176dfc4560ced9f08842ad9f
9 changes: 3 additions & 6 deletions src/main/scala/com/redis/api/TransactionOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
package com.redis
package api

import scala.concurrent.ExecutionContext
import scala.util.{Success, Failure}
import serialization._
import akka.pattern.ask
import akka.util.Timeout
import com.redis.protocol.{TransactionCommands, Discarded}
import ExecutionContext.Implicits.global
import scala.concurrent.ExecutionContext

trait TransactionOperations { this: RedisOps =>
import TransactionCommands._
Expand All @@ -18,7 +15,7 @@ trait TransactionOperations { this: RedisOps =>
def exec()(implicit timeout: Timeout) =
clientRef.ask(Exec).mapTo[Exec.type#Ret]

def discard()(implicit timeout: Timeout) =
def discard()(implicit timeout: Timeout, executor: ExecutionContext) =
clientRef.ask(Discard).mapTo[Discard.type#Ret].map(_ => Discarded)

def watch(keys: Seq[String])(implicit timeout: Timeout) =
Expand All @@ -30,7 +27,7 @@ trait TransactionOperations { this: RedisOps =>
def unwatch()(implicit timeout: Timeout) =
clientRef.ask(Unwatch).mapTo[Unwatch.type#Ret]

def withTransaction(txn: RedisOps => Unit)(implicit timeout: Timeout) = {
def withTransaction(txn: RedisOps => Unit)(implicit timeout: Timeout, executor: ExecutionContext) = {
multi()
try {
txn(this)
Expand Down