Support new CLIENT KILL semantics from Redis 2.8.12+ in tests #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLIENT KILL since version 2.8.12 has a new format: http://redis.io/commands/client-kill The interesting part is `CLIENT KILL SKIPME yes/no`. By default this option is set to yes, which means that something in the sense of client.kill(self) wouldn't work anymore. This commit changes the test to use a different client for killing the desired connection, if the redis version is greater than 2.8.12
Owner
|
Thanks a lot .. will take a look and merge over the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLIENT KILL since version 2.8.12 has a new format:
http://redis.io/commands/client-kill
The interesting part is
CLIENT KILL SKIPME yes/no.By default this option is set to yes, which means that something in the sense of client.kill(self) wouldn't work anymore.
This commit changes the test to use a different client for killing the desired connection, if the redis version is greater than 2.8.12
This does not, however, enable the usage of the new syntax. That is stuff for a new PR.