Skip to content

Replace Akka IO Pipelines with Akka Stream (Reactive Streams) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
knutwalker wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Replace Akka IO Pipelines with Akka Stream (Reactive Streams) #90

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c47fc65
Support CLIENT KILL from Redis 2.8.12+ in tests
knutwalker Jul 15, 2014
f18bb4f
Replace Akka IO Pipelines with Akka Stream (Reactive Streams)
knutwalker Jul 15, 2014
18047c3
Use pipeTo instead of closing over Actor and ActorContext
knutwalker Jul 16, 2014
5f7e1f6
collape consecutive pattern matches into one
knutwalker Jul 17, 2014
687f0bc
add explanation and TODO about jumping back in Boolean parser
knutwalker Jul 26, 2014
89985de
move OK bytes constant to proper location
knutwalker Jul 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
collape consecutive pattern matches into one
  • Loading branch information
@knutwalker
knutwalker committed Jul 17, 2014
commit 5f7e1f6e277f902a4aea717e74c6704a46f4064d
7 changes: 3 additions & 4 deletions src/main/scala/com/redis/pipeline/AkkaStreamTransport.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,9 @@ trait AkkaStreamTransport { me: Actor =>
private def createPipe = context watch context.actorOf(TcpPipeProducer.props())

private def returnToSender(commanderAndResult: (ActorRef, Try[Any])): Unit = {
val (commander, result) = commanderAndResult
result match {
case Success(res) => commander ! res
case Failure(e) => commander ! Status.Failure(e)
commanderAndResult match {
case (commander, Success(res)) => commander ! res
case (commander, Failure(e)) => commander ! Status.Failure(e)
}
}
Copy link

@viktorklang viktorklang Jul 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

commanderAndResult match {
  case (commander, Success(res)) => commander ! res
  case (commander, Failure(e)) => commander ! Status.Failure(e)
}

saves a bit


Expand Down