Fix: Video joining fails on Android 11 #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android 11 stops automatically when receives one.
maff91
force-pushed
the
fix-android-11-join-videos
branch
from
3b25120 to
6e44d91
Compare
NiekAkerboom
referenced
this pull request
in NiekAkerboom/Transcoder
Jan 7, 2021
Android 11 stops automatically when it receives one. This commit has been copied from https://github.com/natario1/Transcoder/pull/108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #107
Starting with Android 11 (tested on the emulator x86_64 and Pixel 2) apparently
MediaMuxeris automatically stopped in the native code when receiving empty "End of stream" buffer.Therefore, when joining multiple clips the mixer gets stoped after receiving the last buffer of the first file. After it can't receive any more data and fails with
E/MediaAdapter: pushBuffer called before startand then
java.lang.IllegalStateException: writeSampleData returned an errorSolution: Don't feed "End of stream" buffers io the muxer.
Thank you, appreciate any feedback 😁