Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4817 commits
Select commit Hold shift + click to select a range
70999d8
[wasm] add new interop to the console template (#72375)
alinpahontu2912 Jul 21, 2022
e092687
Fix x86 GCStress race with indirect calls before epilogs (#72592)
jakobbotsch Jul 21, 2022
6ac841d
Fix minor triple slash comment (#72569)
tarekgh Jul 21, 2022
ed5080a
Fix accidentally removed Add in TypeSpec.AddModifier (#72605)
stephentoub Jul 21, 2022
6c33d4f
Fix TwoServerInstances_OnceDisposed_Throws test for non-overlapped I/…
stephentoub Jul 21, 2022
c2f07f6
Improve RegexCharClass.Analyze for sets with subtraction (#72328)
stephentoub Jul 21, 2022
0b1c61e
Disable NamedPipeTest_ServerInOut_ClientInOut_Synchronous test config…
stephentoub Jul 21, 2022
5b8d9eb
Sleep infinitely on secondary crashing threads (#72618)
jkotas Jul 21, 2022
5044106
Assert compiler diagnostics in UpgradeToRegexGeneratorAnalyzerTests a…
Youssef1313 Jul 21, 2022
0a7d601
Add ease of use helpers in X.509
bartonjs Jul 21, 2022
d700ce9
[wasm] bump npm packages, fix lint errors (#72600)
pavelsavara Jul 21, 2022
f7d7b55
[RateLimiting] Fix test race with timer (#72118)
BrennanConroy Jul 21, 2022
c895d95
[mono] Pass the pending exception correctly from interp_runtime_invok…
vargaz Jul 21, 2022
24f3234
Allow not finding attribute data for more cases that we don't care ab…
jkoritzinsky Jul 21, 2022
bac2229
Avoid AsyncLocal read in Activity.set_Current when CurrentChanged isn…
stephentoub Jul 21, 2022
2f02f12
Support for RequiresAttributeMismatch testing (#72496)
tlakollo Jul 21, 2022
cd24e18
Clarified documentation regarding building the Core_Root. (#72560)
ivdiazsa Jul 21, 2022
63692cd
Revert "Always use live host (#71725)" (#72628)
agocke Jul 21, 2022
5b0baa9
[mono][aot] Pass -mattr=crc32 to opt/llc when sse4.2 is enabled and u…
vargaz Jul 21, 2022
b2e1633
[main] Update dependencies from dotnet/arcade (#72178)
dotnet-maestro[bot] Jul 21, 2022
743f083
Sync shared code from aspnetcore (#72588)
github-actions[bot] Jul 21, 2022
746fc5f
[mono][aot] Don't fail AOT for methods referencing fnptr classes. (#7…
vargaz Jul 21, 2022
a8ef21c
Disable NoStapledOcsp test on Debian 10 for now. (#72634)
bartonjs Jul 22, 2022
0e7432f
amend the LoongArch64-ABI for GCstress and NullableObject. (#72573)
shushanhf Jul 22, 2022
44be09d
Clear list in Enumerable.Chunk prior to yielding (#72637)
stephentoub Jul 22, 2022
c0b9416
Correct nullable annotation on ICustomTypeDescriptor.GetConverter (#7…
eerhardt Jul 22, 2022
8d5c303
Port the doc changes to source (#72638)
tarekgh Jul 22, 2022
4cadf9a
[wasm] Return int from console template (#72623)
radekdoulik Jul 22, 2022
20dd6ea
Add GCDescs in front of MethodTable to dumps (#72658)
Jul 22, 2022
d5d9d52
Fix HttpConnectionPool timers race on disposal (#72615)
CarnaViire Jul 22, 2022
0c32267
Fixes overwrite of last captured managed stack frame address in Event…
lateralusX Jul 22, 2022
a5e678d
Simplify AppModel addToProject settings (#72072)
agocke Jul 22, 2022
ea2c907
Additional tests for Generics in System.Text.Json.SourceGeneration (#…
pos777 Jul 22, 2022
cbe29e8
Fix #72614. (#72630)
eiriktsarpalis Jul 22, 2022
ed5aa3d
[QUIC] Support for OpenSSL build of MsQuic on Windows (Attempt 2) (#7…
rzikm Jul 22, 2022
db6cf45
Fix potential out-of-bounds array accesses in System.Data.Operators (…
stephentoub Jul 22, 2022
e1764aa
Templates outputs ejs instead of cjs (#71951)
yamachu Jul 22, 2022
8c71651
Delete ConservativelyReportedRegion and CallingConventionConverterHel…
jkotas Jul 22, 2022
41def7c
[NativeAOT] Some cleanup of assembly helpers in hijack area. (#72542)
VSadov Jul 22, 2022
555a791
Add `UnscopedRefAttribute` (#72499)
AaronRobinsonMSFT Jul 22, 2022
434fe75
HTTP/3 Improved message for failing QUIC connection (#72374)
iuliaco Jul 22, 2022
a969c53
Remove wrong cgroups assert (#72372)
janvorli Jul 22, 2022
0fbdb1e
Fix Globalization tests (#72653)
LakshanF Jul 22, 2022
8eeb4df
Bump Intellisense package version to Preview6 (#72631)
carlossanlop Jul 22, 2022
a8e3e7d
PipeReaderStream.ReadInternal throws AggregateException unexpectedly …
pedrobsaila Jul 22, 2022
391d143
Disable failing System.Text.Json tests on Android x86 and on Browser …
simonrozsival Jul 22, 2022
885207f
Add missing nullability annotation in CodeDom (#72532)
DustinCampbell Jul 22, 2022
bca7f94
Fix DivRem bug (#72115)
dakersnar Jul 22, 2022
574fd3a
Disable ThrowDuringProcessLog_ShutsDownGracefully test (#72680)
eerhardt Jul 22, 2022
fce6549
Add support for static default interface methods (#72661)
MichalStrehovsky Jul 22, 2022
a68ab4a
Change PipeStream's sync I/O cancellation support to avoid blocking C…
stephentoub Jul 22, 2022
5a073b2
Utilize new C# support for nameof in attributes in same signature (#7…
stephentoub Jul 22, 2022
c59b517
Add X509AuthorityKeyIdentifierExtension
bartonjs Jul 22, 2022
768500c
Tighten nullable annotations on RegistryKey.GetValue (#72679)
stephentoub Jul 22, 2022
7eaa6d1
Support ICU on Windows Server 2019 (#72656)
tarekgh Jul 22, 2022
5097317
Respect ForceUTF8Encoding when encoding an X500DN
vcsjones Jul 22, 2022
463efbb
Fix debugger funceval deadlock (#72179)
noahfalk Jul 22, 2022
04ff6c1
Add markdown readme for Microsoft.Extensions.DependencyModel (#72660)
MSDN-WhiteKnight Jul 23, 2022
4735fd7
Include libnethost.pdb in implementation packages (#72688)
elinor-fung Jul 23, 2022
1e1e86d
`LibraryImport` generator `AllowUnsafeBlocks` diagnostic (#72650)
AaronRobinsonMSFT Jul 23, 2022
d5b718f
Fix ClonedServer_ActsAsOriginalServer test (#72698)
stephentoub Jul 23, 2022
44397be
Improve reliability of WarningsAsErrors replacement (#72070)
GrabYourPitchforks Jul 23, 2022
02ee890
Update some more dependencies pulling in Newtonsoft.Json 9.0.1 (#72662)
jakobbotsch Jul 23, 2022
cbfc549
Improve performance of RegistryKey.GetValue (#66918)
stephentoub Jul 23, 2022
2bcf0f7
Delete lvVerTypeInfo (#71597)
SingleAccretion Jul 23, 2022
c624626
Consolidate importer spilling code (#72291)
SingleAccretion Jul 23, 2022
f0e7a68
[main] Update dependencies from dotnet/linker (#72597)
dotnet-maestro[bot] Jul 23, 2022
9d6396d
Fix typos (#72709)
am11 Jul 24, 2022
93f0512
[QUIC] Return connection dispose in H3loopback connection (#72713)
ManickaP Jul 24, 2022
50c0291
[main] Update dependencies from dotnet/arcade (#72672)
dotnet-maestro[bot] Jul 24, 2022
f4b9bac
Fix nativeaot arm64 build on macOS (#72733)
am11 Jul 24, 2022
c22f7f8
Revert "Consolidate importer spilling code (#72291)" (#72738)
jkotas Jul 24, 2022
c9c27d4
Avoid unnecessary return val copying in tailcall-via-help (#72720)
jakobbotsch Jul 24, 2022
b5fd812
Fixed stress error System.Exception: Completed unexpectedly (#72734)
ManickaP Jul 24, 2022
9f68db2
Replace a static readonly in[] in System.Data.Common (#72743)
stephentoub Jul 24, 2022
214ca6d
Avoid some unnecessary static readonly arrays (#72727)
stephentoub Jul 24, 2022
02ffbcd
Avoid transformation from multiplication to left shift in case of 64 …
alhad-deshpande Jul 25, 2022
7ec4304
Fix ReflectionCachesUpdateHandler_CachesCleared test in aggressive tr…
eerhardt Jul 25, 2022
9a0b8f3
[mono] Include dynamic methods in stacktrace (#72732)
BrzVlad Jul 25, 2022
60cfaec
Fix ARM64 Unix debugging (#72735)
hoyosjs Jul 25, 2022
6bbaed4
[wasm][debugger] Fix test regressions (#72751)
radical Jul 25, 2022
98d3841
Revert "Detect truncated GZip streams (#61768)" (#72742)
stephentoub Jul 25, 2022
a1468ed
Ensure `GetCorElementType` returns value type for enums on Mono runti…
mathieubourgeois Jul 25, 2022
a0cd16e
Fix SendAsync_GetWithInvalidHostHeader_ThrowsException (#72779)
rzikm Jul 25, 2022
d98066f
Expands a list of always trimmed mobile+web CA with few recently adde…
marek-safar Jul 25, 2022
b4991a5
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot Jul 25, 2022
dfd6efc
TryAddWithoutValidation ViaHeaderValue (#72741)
feiyun0112 Jul 25, 2022
91d15ff
JIT: teach VN to fold type comparisons (#72136)
AndyAyersMS Jul 25, 2022
f078ca9
Include EventLog.Messages in WindowsDesktop pack (#72280)
ViktorHofer Jul 25, 2022
283d6e6
[mono][llvm] Fix generation of LLVM IR for OP_SSE_CVTII. (#72731)
vargaz Jul 25, 2022
c9d7854
Enable NJulianRuleTest (#72707)
tarekgh Jul 25, 2022
9a461ad
Delete dead code from and fix `getSIMDStructFromField` (#71226)
SingleAccretion Jul 25, 2022
7aaa279
[wasm-ep] Implement DiagnosticServer and startup sessions for WebAsse…
lambdageek Jul 25, 2022
309ab38
fix project references, transient dependency doesn't work great on wi…
pavelsavara Jul 25, 2022
16f13eb
Dispose of IncrementalHash in CmsSigner
vcsjones Jul 25, 2022
f175438
when building on Ubuntu, avoid warning on shlibdeps libSystem.IO.Comp…
mirespace Jul 25, 2022
e83493e
Improve String.EndsWith for OrdinalIgnoreCase (#72750)
EgorBo Jul 25, 2022
fb1d318
Enable NI_Vector256_Create on AVX1 (#72522)
EgorBo Jul 25, 2022
5e91aa4
Re-enable the ability to use in-build signing (#72690)
mmitche Jul 25, 2022
bbdd837
[iOS] Enable Diagnostics.Tracing tests (#72545)
steveisok Jul 25, 2022
193fd53
JIT: add more inlining bail out checks (#72795)
AndyAyersMS Jul 25, 2022
ed2a5a1
[wasm] Move some defaults out of the templates (#72626)
lewing Jul 25, 2022
a660c0f
Fix MemoryCache test failures due to race (#72821)
danmoseley Jul 26, 2022
75476f9
Represent field RVA data with a dedicated node (#72826)
MichalStrehovsky Jul 26, 2022
d9da50c
Bail second pass redirection after catch in thread abort on Unix (#72…
hoyosjs Jul 26, 2022
b5de033
Fix HttpListenerRequestUriBuilder.GetPath's search for `?` (#72794)
stephentoub Jul 26, 2022
5166975
JIT: Fix creating small-typed LCL_VAR nodes in fgMakeTemp (#72771)
jakobbotsch Jul 26, 2022
86a7742
Removing the PublishAot check from the SDK (#72820)
LakshanF Jul 26, 2022
73374e8
[wasm] improve startup (#72275)
pavelsavara Jul 26, 2022
336317a
Emit warning instead of an error in package compat (#72518)
ViktorHofer Jul 26, 2022
e893232
[iOS] Enable System.Data.Common tests (#72554)
mdh1418 Jul 26, 2022
c118395
Fix running HTTP stress tests on local docker (#72844)
CarnaViire Jul 26, 2022
faebe45
Remove Http3RequestStream from _activeRequest when response is read/a…
rzikm Jul 26, 2022
2a2edc8
[wasm] optimize WebSocket perf for small buffers (#72800)
pavelsavara Jul 26, 2022
124ba53
Make RateLimiterOptions follow Options pattern (#72530)
wtgodbe Jul 26, 2022
fefb910
Clarify the purpose of the official discord (#72861)
MichalPetryka Jul 26, 2022
edb30e7
Add CertificateRevocationListBuilder
bartonjs Jul 26, 2022
dcf40dd
Fix missing shifting of Match._textxx fields (#72728)
stephentoub Jul 26, 2022
f4cb6ac
Add analyzer support to validate the stateless marshaller shapes (#72…
jkoritzinsky Jul 26, 2022
dbb97ca
Fix for #70007, fallback to old implementation if optimized way fails…
schuettecarsten Jul 26, 2022
8fc7be6
System.Text.Json - Emit XML comments for public source-generated APIs…
JakeYallop Jul 26, 2022
39d82c9
[QUIC] Remove connection state from QuicStream (#72599)
ManickaP Jul 26, 2022
cea17b2
Consolidate importer spilling code V2 (#72744)
SingleAccretion Jul 26, 2022
33d033d
Enable the ConvertToLibraryImport diagnostic by default (#72819)
jkoritzinsky Jul 26, 2022
cb046e5
Enabling some tests back onto the Interpreted engine (#72639)
joperezr Jul 26, 2022
1d08472
Change RegexGenerator to produce limited implementation for C# < 11 (…
stephentoub Jul 26, 2022
ccb9c26
Add pod names into the area-owners.json file to support querying by p…
jeffhandley Jul 26, 2022
d9887e5
Finds logger field in related types (#71308)
SteveDunn Jul 26, 2022
cc7ccfd
Fix Idna Test (#72817)
tarekgh Jul 26, 2022
1729ca6
Tear down pending HTTP connection when the originating request comple…
antonfirsov Jul 26, 2022
da46270
Make TypeBuilder.CreateType return non nullable (#72180)
JosieBigler Jul 26, 2022
0be6c64
Fix EncryptDecrypt test (#72874)
danmoseley Jul 26, 2022
aa5ff31
[wasm] Add `runtime-wasm-perf` pipeline (#72119)
radical Jul 26, 2022
f652b24
Add missing case in PruneLowerPriorityThanNullability (#72871)
olsaarik Jul 26, 2022
891cc3a
Simplify UpgradeToRegexGenerator (#72538)
Youssef1313 Jul 26, 2022
14ad0e1
Fix undisposed RegistryKeys in Microsoft.Win32.Registry tests (#72117)
stephentoub Jul 27, 2022
3c25f59
Avoid a couple theoretical reorderings in ManualResetValueTaskSourceC…
stephentoub Jul 27, 2022
1f98974
Fix Enumerable.Chunk throughput regression (#72811)
stephentoub Jul 27, 2022
fbced1b
[iOS] Fix ZipPackage_CreateWithFileAccessWrite test (#72850)
steveisok Jul 27, 2022
c421a7c
[iOS] Skip test suites that take too long to build on helix (#72849)
steveisok Jul 27, 2022
3ddc2c4
Add [Shared] to two CodeFixProviders (#72885)
stephentoub Jul 27, 2022
e125acf
Change issue number (#72863)
simonrozsival Jul 27, 2022
2c31641
Exclude JIT/opt/ValueNumbering/TypeTestFolding from crossgen2 testing…
AndyAyersMS Jul 27, 2022
8abc251
Update upstream ref for arm fp unwind support (#71857)
am11 Jul 27, 2022
75cc8fa
Add a test that ensures we are using SubtleCrypto in WASM crypto test…
eerhardt Jul 27, 2022
c4a8c8a
Delete DelegateInvokeThunk (#72903)
jkotas Jul 27, 2022
f90028c
Redisable GetAndSet_AreThreadSafe_AndUpdatesNeverLeavesNullValues tes…
danmoseley Jul 27, 2022
4f54504
Don't create mismatched block copies in `cpblk` import (#71160)
SingleAccretion Jul 27, 2022
b01f4a8
[main] Update dependencies from 8 repositories (#72448)
dotnet-maestro[bot] Jul 27, 2022
60e5f40
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot Jul 27, 2022
35d1171
[mini] Emit a null check using MONO_EMIT_NEW_CHECK_THIS for GetArrayD…
lambdageek Jul 27, 2022
ac48faa
Add missing System.Net docs (#72459)
stephentoub Jul 27, 2022
c867be6
enable https://github.com/dotnet/runtime/issues/53957 and https://git…
pavelsavara Jul 27, 2022
7b435cf
Enable GitHub_35821 (#72900)
kunalspathak Jul 27, 2022
7177b9d
JIT: Avoid removing multi-use boxes (#72842)
jakobbotsch Jul 27, 2022
3367b35
Fix a couple of issues when using textual PGO input (#72773)
jakobbotsch Jul 27, 2022
2725510
Re-enable throwinnestedtrycatch_il_r test (#72901)
kunalspathak Jul 27, 2022
56a1cf4
Bump timeout for "CoreCLR Tools Unit Tests Linux x64 checked" (#72928)
akoeplinger Jul 27, 2022
96b4b53
Remove InvalidOperationException when reading system properties from …
ericstj Jul 27, 2022
b416ee7
Fix the NJulianRuleTest when running with libc check builds (#72893)
tarekgh Jul 27, 2022
97f5a04
Disable ReadAsync_CancelPendingValueTask_ThrowsCancellationException …
rzikm Jul 27, 2022
d7d0e42
[wasm] Modify workload to pick threading runtime packs (#72412)
steveisok Jul 27, 2022
fc7577b
Add BuildCrlDistributionPointExtension
bartonjs Jul 27, 2022
a92bd72
Add support for int keyed dictionaries to configuration binder (#71609)
beppemarazzi Jul 27, 2022
c21ae04
[Mono][Arm64] Instrinsify methods for Vector4 on Arm64 (#72124)
fanyang-mono Jul 27, 2022
cd7db35
CMake support in VS open folder for coreclr (#70285)
huoyaoyuan Jul 27, 2022
dd98eac
Disable CrlBuilderTests.BuildEmptyRsaPss on Android
bartonjs Jul 27, 2022
d944592
Make revocation tests use CRLBuilder when it can instead of its own copy
bartonjs Jul 27, 2022
ada5503
Add SqlTypes apis for SqlClient (#72724)
Wraith2 Jul 27, 2022
111100b
Remove a few hardcoded instances of "net7.0" (#72950)
akoeplinger Jul 27, 2022
e96cfa9
Fixed HWIntrinsic reflection bug with `NextCallReturnAddress` intrins…
TIHan Jul 28, 2022
b0090d0
Rename [RegexGenerator] to [GeneratedRegex] (#72434)
am11 Jul 28, 2022
950f407
Disable tests that wait for compaction (#72954)
danmoseley Jul 28, 2022
34ea135
Add memory fences to ByRefAssignRef on Unix ARM64 (#72919)
MichalStrehovsky Jul 28, 2022
79d1988
[wasm][wbt] Test that `dotnet.js` could be run from any current direc…
yamachu Jul 28, 2022
426c959
Bump timeout on ARM64 NativeAOT legs (#72974)
MichalStrehovsky Jul 28, 2022
490d3ce
Minor cleanup in MethodDesc::GetPrecompiledCode (#72963)
hoyosjs Jul 28, 2022
9390088
Add extra Module.ModuleHandle test (#72875)
marek-safar Jul 28, 2022
d365ff2
Implement ControlledExecution API (#71661)
AntonLapounov Jul 28, 2022
8fdec7f
[wasm] remove support for CommonJS (#72865)
pavelsavara Jul 28, 2022
ee4e890
#53624 enable test suites in maccatalyst (#72445)
mkhamoyan Jul 28, 2022
97749c0
[wasm] Wasm.Build.Tests: Use Chrome on windows, instead of V8 (#72983)
radical Jul 28, 2022
9dfc922
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot Jul 28, 2022
d641668
Fix evaluate expression of mutidimensional array. (#72964)
thaystg Jul 28, 2022
b31a48a
Fix SslStress docker build (#72940)
antonfirsov Jul 28, 2022
b0766a9
[wasm][debugger] Added support for getting members of static structur…
ilonatommy Jul 28, 2022
0cd410b
[libs][mono] Enable diagnostics_tracing runtime component in Android …
mdh1418 Jul 28, 2022
e6723a3
JIT: Skip Min/Max optimization when SSE2 is not enabled (#72991)
jakobbotsch Jul 28, 2022
50d69de
Enable tests disabled by issue 36882 (#72931)
lateralusX Jul 28, 2022
a8789a6
Fix race when receiving HEADERS and RST_STREAM in rapid succession. (…
rzikm Jul 28, 2022
8e1c9c1
[mono][jit] Use MONO_CLASS_IS_SIMD () in more places to fix running w…
vargaz Jul 28, 2022
11e3d1b
Fix `ldelem[a]/stelem/cpobj/ldobj/stobj <pointer type>` import (#71679)
SingleAccretion Jul 28, 2022
812ad81
HTTP/3 Made alt-used show only on alt-svc redirect (#72669)
iuliaco Jul 28, 2022
1e01aa1
Annoating Net.Quic & Net.Security libraries to be AOT safe (#72791)
LakshanF Jul 28, 2022
e7c83f1
Use the common path for lowering single-reg SIMD returns (#72944)
SingleAccretion Jul 28, 2022
ad58ce5
Added remaining APIs to complete NativeMemory set (#72960)
sakno Jul 28, 2022
cf3bf7a
Update the CustomMarshallerAttributeFixer to support adding missing m…
jkoritzinsky Jul 28, 2022
35b8617
Avoid promoting in sweep_in_plan when we already decided not to promo…
cshung Jul 28, 2022
ef7c980
Do not embed result type in VN for scalar hw intrinsics (#72895)
kunalspathak Jul 28, 2022
07ebba1
[wasm][debugger] Fix assert when passing an invalid array to runtime.…
thaystg Jul 28, 2022
d7c8bc1
[wasm] reduce legacy interop usage (#72021)
pavelsavara Jul 28, 2022
bda5557
Add support for specifying Kerberos package on Linux/macOS (in additi…
filipnavara Jul 28, 2022
74bd485
Remove some debug code (#72985)
AaronRobinsonMSFT Jul 28, 2022
8294512
JIT: Disqualify methods with modifiable `this` from OSR. (#72877)
AndyAyersMS Jul 29, 2022
7d1e1af
Get more libraries tests running with NativeAOT (#72917)
MichalStrehovsky Jul 29, 2022
1c055bb
Run more test on NativeAOT Linux (#72832)
MichalStrehovsky Jul 29, 2022
cc7edab
Implementation of opcode OP_GC_SAFE_POINT for ppc64le (#72997)
alhad-deshpande Jul 29, 2022
2781e17
Fixing the per object hard limit support for regions (#72229)
cshung Jul 29, 2022
b6115b0
Unblock tests blocked on 70012 (#73044)
MichalStrehovsky Jul 29, 2022
9b63001
Make JSON support required properties (#72937)
krwq Jul 29, 2022
5331568
[NativeAOT] Fix assert in Thread.SpinWait(0) (#73033)
VSadov Jul 29, 2022
7ca4d6f
Fix UnsupportedOSPlatformAttribute usage in System.Net.NetworkInforma…
rzikm Jul 29, 2022
c734a8e
[wasm-ep] diagnostic server IPC fixups (#72859)
lambdageek Jul 29, 2022
20b42d5
re-enable tests for 66421 (#73052)
krwq Jul 29, 2022
44f1c1e
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot Jul 29, 2022
992cf8c
Define __cpuid{ex} only when there's no builtin one (#73065)
am11 Jul 29, 2022
222da17
[wasm] `JSImport` generator `AllowUnsafeBlocks` diagnostic (#72996)
pavelsavara Jul 29, 2022
c0d16fa
recursive generic fix (#73071)
VSadov Jul 29, 2022
f03470b
Refactor root-level serialization logic and polymorphic value handlin…
eiriktsarpalis Jul 29, 2022
de25ece
Fix crc32 issues found in #62692 (#73005)
EgorBo Jul 29, 2022
865802a
Fix incremental XxHash32/XxHash64 (#69185)
froce Jul 29, 2022
32f3646
Update ConvertToLibraryImport analyzer and fixer to limit false-posit…
jkoritzinsky Jul 29, 2022
a01aea9
Add stateful marshaller support to the CustomMarshallerAttributeAnaly…
jkoritzinsky Jul 29, 2022
4cd3e78
Add EH filters for generic catch(T) blocks (#72721)
EgorBo Jul 29, 2022
d30ab11
Disable NJulianRuleTest on Android (#73030)
tarekgh Jul 29, 2022
1dc6524
Appropriately free temporary values on EC import
bartonjs Jul 29, 2022
1f0571e
Annotate System.Linq.Queryable with RDC (#72899)
agocke Jul 30, 2022
0ba3d31
Move System.ValueType.s_seed into System.Runtime.CompilerServices.Run…
gregg-miskelly Jul 30, 2022
9481422
Add retry to symlink test (#73042)
danmoseley Jul 30, 2022
aa8489c
Implement test checking whether CET is active (#71509)
trylek Jul 30, 2022
17a4eca
Remove undefined behavior for address of null reference (#73113)
AaronRobinsonMSFT Jul 31, 2022
ec5e8b5
[GC] Handle objects from frozen segments in GCHeap::IsEphemeral (#73110)
EgorBo Jul 31, 2022
eead714
[Android] Don't exclude .gz files from assets.zip (#73077)
directhex Jul 31, 2022
5e6df13
JIT: have jit tail call stress avoid creating loops in some cases (#7…
AndyAyersMS Jul 31, 2022
85beaec
30% optimization of `DateTime.GetDate()`/`.Year/.Month/.Day/.DayOfYea…
SergeiPavlov Jul 31, 2022
13b4bb7
Add documentation for hot/cold splitting (#73029)
Jul 31, 2022
d07b800
Add TPN entry for Date/Time processing algorithm (#73128)
danmoseley Jul 31, 2022
3605700
Update CLRConfig knob description (#73133)
AaronRobinsonMSFT Aug 1, 2022
508fef5
Enable more libraries tests (#73104)
MichalStrehovsky Aug 1, 2022
75abdd4
Fix assert in NativeAOT when handling data flow on compiler generated…
vitek-karas Aug 1, 2022
3b35bc6
Link issue to the RDC attribute on DispatchProxy (#73137)
MichalStrehovsky Aug 1, 2022
cfa4f6f
Add some QuicListener tests (#73072)
rzikm Aug 1, 2022
65af9d0
Add localloc empty stack verification (#73109)
jl0pd Aug 1, 2022
01444f7
[mono][interp] Improve tiering performance (#70649)
BrzVlad Aug 1, 2022
05c6f3d
Add more DataFlow tests from linker to NativeAOT (#72777)
vitek-karas Aug 1, 2022
f1de614
[Unix] Console.ReadKey rewrite (#72193)
adamsitnik Aug 1, 2022
2f78734
Remove cctor from X500NameEncoder (#73115)
vcsjones Aug 1, 2022
8eb5dea
Remove 1024 character limit on ODBC connection strings (#73149)
roji Aug 1, 2022
cfe26ec
Don't hardcode /tmp in named pipe tests, it's not for us on Android (…
directhex Aug 1, 2022
028e556
Make IHostEnvironment.ApplicationName non-nullable (#72945)
eerhardt Aug 1, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Prev Previous commit
Next Next commit
Fix typos (dotnet#72709)
  • Loading branch information
am11 authored Jul 24, 2022
commit 9d6396deb02161f5ee47af72ccac52c2e1bae458
2 changes: 1 addition & 1 deletion docs/coding-guidelines/mono-code-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Macros generally use a `MONO_` prefix. Macros in public API headers *must* use

Prefer the standard C sized types `int32_t`, `intptr_t`, etc over the eglib types `gint32`, `gsize` etc.

One exception is `gboolean` is prefered over C `bool`.
One exception is `gboolean` is preferred over C `bool`.

There are actually three boolean types to keep in mind:

Expand Down
4 changes: 2 additions & 2 deletions docs/design/coreclr/botr/clr-abi.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# CLR ABI

This document describes the .NET Common Language Runtime (CLR) software conventions (or ABI, "Application Binary Interface"). It focusses on the ABI for the x64 (aka, AMD64), ARM (aka, ARM32 or Thumb-2), and ARM64 processor architectures. Documentation for the x86 ABI is somewhat scant, but information on the basics of the calling convention is included at the bottom of this document.
This document describes the .NET Common Language Runtime (CLR) software conventions (or ABI, "Application Binary Interface"). It focuses on the ABI for the x64 (aka, AMD64), ARM (aka, ARM32 or Thumb-2), and ARM64 processor architectures. Documentation for the x86 ABI is somewhat scant, but information on the basics of the calling convention is included at the bottom of this document.

It describes requirements that the Just-In-Time (JIT) compiler imposes on the VM and vice-versa.

Expand Down Expand Up @@ -153,7 +153,7 @@ The below is performed when the GC transition is not suppressed.
2. For JIT64/AMD64 only: Next for non-IL stubs, the InlinedCallFrame is 'pushed' by setting `Thread->m_pFrame` to point to the InlinedCallFrame (recall that the per-frame initialization already set `InlinedCallFrame->m_pNext` to point to the previous top). For IL stubs this step is accomplished in the per-frame initialization.
3. The Frame is made active by setting `InlinedCallFrame->m_pCallerReturnAddress`.
4. The code then toggles the GC mode by setting `Thread->m_fPreemptiveGCDisabled = 0`.
5. Starting now, no GC pointers may be live in registers. RyuJit LSRA meets this requirement by adding special refPositon `RefTypeKillGCRefs` before unmanaged calls and special helpers.
5. Starting now, no GC pointers may be live in registers. RyuJit LSRA meets this requirement by adding special refPosition `RefTypeKillGCRefs` before unmanaged calls and special helpers.
6. Then comes the actual call/PInvoke.
7. The GC mode is set back by setting `Thread->m_fPreemptiveGCDisabled = 1`.
8. Then we check to see if `g_TrapReturningThreads` is set (non-zero). If it is, we call `CORINFO_HELP_STOP_FOR_GC`.
Expand Down
2 changes: 1 addition & 1 deletion docs/design/coreclr/botr/dac-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ Both methodCold and methodCode are declared as `BYTE *`, but in fact hold target

If this code seems overly complex and confusing to you, that's good. In fact it is. Worse, it provides no protection for the separation of host and target addresses. From the declarations of `methodCold` and `methodCode`, there is no particular reason to interpret them as target addresses at all. If these pointers were dereferenced in DAC builds as if they really were host pointers, the process would probably AV. This snippet demonstrates that any arbitrary pointer type (as opposed to a `PTR` type) can be casted to a `TADDR`. Given that these two variables always hold target addresses, they should be of type `PTR_BYTE`, rather than `BYTE *`.

There is also a disciplined means to cast between different `PTR` types: `dac_cast`. The `dac_cast` operator is the DAC-aware vesion of the C++ `static_cast` operator (which the CLR coding conventions stipulate instead of C-style casts when casting pointer types). The `dac_cast` operator will do any of the following things:
There is also a disciplined means to cast between different `PTR` types: `dac_cast`. The `dac_cast` operator is the DAC-aware version of the C++ `static_cast` operator (which the CLR coding conventions stipulate instead of C-style casts when casting pointer types). The `dac_cast` operator will do any of the following things:

1. Create a `PTR` type from a `TADDR`
2. Convert one `PTR` type to another
Expand Down
2 changes: 1 addition & 1 deletion docs/design/coreclr/botr/exceptions.md
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ When a C++ exception is thrown, and there is a missing UACH, the typical failure
Runtime code into managed code
------------------------------

The transition from the runtime into managed code has highly platform-dependent requirements. On 32-bit Windows platforms, the CLR's managed exception code requires that "COMPlusFrameHandler" is installed just before entering managed code. These transitions are handled by highly specialized helper functions, which take care of the appropriate exception handlers. It is very unlikely that any typical new calls into managed would use any other way in. In the event that the COMPlusFrameHander were missing, the most likely effect would be that exception handling code in the target managed code simply wouldn't be executed – no finally blocks, and no catch blocks.
The transition from the runtime into managed code has highly platform-dependent requirements. On 32-bit Windows platforms, the CLR's managed exception code requires that "COMPlusFrameHandler" is installed just before entering managed code. These transitions are handled by highly specialized helper functions, which take care of the appropriate exception handlers. It is very unlikely that any typical new calls into managed would use any other way in. In the event that the COMPlusFrameHandler were missing, the most likely effect would be that exception handling code in the target managed code simply wouldn't be executed – no finally blocks, and no catch blocks.

Runtime code into external native code
--------------------------------------
Expand Down
6 changes: 3 additions & 3 deletions docs/design/coreclr/botr/guide-for-porting.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ The process follows the following strategy
not maintained as generally working. It is expected that the interpreter
will take 1-2 months to enable for an engineer familiar with the CoreCLR
codebase. A functional interpreter allows the porting team to have a set of
engineers which focus exclusively on the JIT and a set which focusses on the
engineers which focus exclusively on the JIT and a set which focuses on the
VM portion of the runtime.

- Build up a set of scripts that will run the coreclr tests. The normal
Expand Down Expand Up @@ -311,7 +311,7 @@ must implement.
components. The implementation made architecture specific via a long series of
C preprocessor macros.

6. `gcinfodecoder.h` The GC info format is archictecture specific as it holds
6. `gcinfodecoder.h` The GC info format is architecture specific as it holds
information about which specific registers hold GC data. The implementation
is generally simplified to be defined in terms of register numbers, but if
the architecture has more registers available for use than existing architectures
Expand Down Expand Up @@ -378,7 +378,7 @@ Here is an annotated list of the stubs implemented for Unix on Arm64.

9. `TheUMEntryPrestub`/ `UMThunkStub` - used to enter the runtime from
non-managed code through entrypoints generated from the
Marshal.GetFunctionPointerForDelagate api.
Marshal.GetFunctionPointerForDelegate api.

10. `OnHijackTripThread` - needed for thread suspension to support GC + other
suspension requiring events. This is typically not needed for very early
Expand Down
2 changes: 1 addition & 1 deletion docs/design/coreclr/botr/managed-type-system.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,4 @@ The type system implementation is found in:

## Notable differences from CoreCLR type system

* `MethodDesc` has exact generic instantations where possible in managed type system. The code sharing policy in managed type system is one of the pluggable algorithms and it does not affect `MethodDesc` identity. The code sharing policy in the CoreCLR type system is coupled with `MethodDesc` identity. See https://github.com/dotnet/runtime/pull/45744 for an example how this difference manifests itself.
* `MethodDesc` has exact generic instantiations where possible in managed type system. The code sharing policy in managed type system is one of the pluggable algorithms and it does not affect `MethodDesc` identity. The code sharing policy in the CoreCLR type system is coupled with `MethodDesc` identity. See https://github.com/dotnet/runtime/pull/45744 for an example how this difference manifests itself.
6 changes: 3 additions & 3 deletions docs/design/coreclr/botr/readytorun-format.md
Original file line number Diff line number Diff line change
Expand Up @@ -702,11 +702,11 @@ To see this in action, we can take a look at the following example, with these o
| R | 0x1234 |
| S | 0x1238 |

Suppose we decided to have only two buckets, then only the least signficant digit will be used to index the table, the whole hash table will look like this:
Suppose we decided to have only two buckets, then only the least significant digit will be used to index the table, the whole hash table will look like this:

| Part | Offset | Content | Meaning |
|:--------|:-------|:--------:|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| Header | 0 | 0x04 | This is the header, the least signficant bit is `00`, therefore the table cell is just one byte. The most significant six bit represents 1, which means the number of buckets is 2^1 = 2. |
| Header | 0 | 0x04 | This is the header, the least significant bit is `00`, therefore the table cell is just one byte. The most significant six bit represents 1, which means the number of buckets is 2^1 = 2. |
| Table | 1 | 0x08 | This is the representation of the unsigned integer 4, which correspond to the offset of the bucket correspond to hash code `0`. |
| Table | 2 | 0x14 | This is the representation of the unsigned integer 10, which correspond to the offset of the bucket correspond to hash code `1`. |
| Table | 3 | 0x18 | This is the representation of the unsigned integer 12, which correspond to the offset of the end of the whole hash table. |
Expand Down Expand Up @@ -835,7 +835,7 @@ enum ReadyToRunHelper
READYTORUN_HELPER_FltRound = 0xE3,

#ifndef _TARGET_X86_
// Personality rountines
// Personality routines
READYTORUN_HELPER_PersonalityRoutine = 0xF0,
READYTORUN_HELPER_PersonalityRoutineFilterFunclet = 0xF1,
#endif
Expand Down
2 changes: 1 addition & 1 deletion docs/design/coreclr/botr/shared-generics.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ The first N slots in an instantiation of N arguments are always going to be the

For instance, here is an example of the contents of the generic dictionary for our `Method<string>` example:

| `Method<string>'s dicionary` |
| `Method<string>'s dictionary` |
|--------------------------|
| slot[0]: TypeHandle(`string`) |
| slot[1]: Total dictionary size |
Expand Down
6 changes: 3 additions & 3 deletions docs/design/coreclr/botr/threading.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,9 @@ Hijacking for GC suspension is done by Thread::SysSuspendForGC. This method atte
2. Get the current CONTEXT for the thread, via GetThreadContext. This is an OS concept; CONTEXT represents the current register state of the thread. This allows us to inspect its instruction pointer, and thus determine what type of code it is currently executing.
3. Check again if the thread is in cooperative mode, as it may have already left cooperative mode before it could be suspended. If so, the thread is in dangerous territory: the thread may be executing arbitrary native code, and must be resumed immediately to avoid deadlocks.
4. Check if the thread is running managed code. It is possible that it is executing native VM code in cooperative mode (see Synchronization, below), in which case the thread must be immediately resumed as in the previous step.
5. Now the thread is suspended in managed code. Depending on whether that code is fully- or partially-interruptable, one of the following is performed:
* If fully interruptable, it is safe to perform a GC at any point, since the thread is, by definition, at a safe point. It is reasonable to leave the thread suspended at this point (because it's safe) but various historical OS bugs prevent this from working, because the CONTEXT retrieved earlier may be corrupt). Instead, the thread's instruction pointer is overwritten, redirecting it to a stub that will capture a more complete CONTEXT, leave cooperative mode, wait for the GC to complete, reenter cooperative mode, and restore the thread to its previous state.
* If partially-interruptable, the thread is, by definition, not at a safe point. However, the caller will be at a safe point (method transition). Using that knowledge, the CLR "hijacks" the top-most stack frame's return address (physically overwrite that location on the stack) with a stub similar to the one used for fully-interruptable code. When the method returns, it will no longer return to its actual caller, but rather to the stub (the method may also perform a GC poll, inserted by the JIT, before that point, which will cause it to leave cooperative mode and undo the hijack).
5. Now the thread is suspended in managed code. Depending on whether that code is fully- or partially-interruptible, one of the following is performed:
* If fully interruptible, it is safe to perform a GC at any point, since the thread is, by definition, at a safe point. It is reasonable to leave the thread suspended at this point (because it's safe) but various historical OS bugs prevent this from working, because the CONTEXT retrieved earlier may be corrupt). Instead, the thread's instruction pointer is overwritten, redirecting it to a stub that will capture a more complete CONTEXT, leave cooperative mode, wait for the GC to complete, reenter cooperative mode, and restore the thread to its previous state.
* If partially-interruptible, the thread is, by definition, not at a safe point. However, the caller will be at a safe point (method transition). Using that knowledge, the CLR "hijacks" the top-most stack frame's return address (physically overwrite that location on the stack) with a stub similar to the one used for fully-interruptible code. When the method returns, it will no longer return to its actual caller, but rather to the stub (the method may also perform a GC poll, inserted by the JIT, before that point, which will cause it to leave cooperative mode and undo the hijack).

ThreadAbort / AppDomain-Unload
==============================
Expand Down
2 changes: 1 addition & 1 deletion docs/design/coreclr/botr/vectors-and-intrinsics.md
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ Code will be compiled using the optimistic instruction set to drive compilation,
- Any use of a platform intrinsic in the codebase SHOULD be wrapped with a call to the associated IsSupported property. This wrapping may be done within the same function that uses the hardware intrinsic, but this is not required as long as the programmer can control all entrypoints to a function that uses the hardware intrinsic.
- If an application developer is highly concerned about startup performance, developers should avoid use intrinsics beyond Sse42, or should use Crossgen with an updated baseline instruction set support.

### Crossgen2 ajustment to rules for System.Private.CoreLib.dll
### Crossgen2 adjustment to rules for System.Private.CoreLib.dll
Since System.Private.CoreLib.dll is known to be code reviewed with the code review rules as written above for crossgen1 with System.Private.CoreLib.dll, it is possible to relax rule "Code which attempts to use instruction sets outside of the optimistic set will generate code that will not be used on machines with support for the instruction set." What this will do is allow the generation of non-optimal code for these situations, but through the magic of code review, the generated logic will still work correctly.


Expand Down
4 changes: 2 additions & 2 deletions docs/design/coreclr/jit/eh-writethru.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ There are a number of wrinkles informing this design based on how the JIT models
- The jit does not model which handlers are reachable from a given protected region,
so considers a variable live into a handler if it is live into any handler in the method.

It is posible to do better than the "store every definition" approach outlined
in the design, but the expectation is that this would require posibly
It is possible to do better than the "store every definition" approach outlined
in the design, but the expectation is that this would require possibly
modifying the model in the JIT and staging more throughput intensive analyses.
With these considerations this design was selected and further improvements
left to future optimization.
Expand Down
4 changes: 2 additions & 2 deletions docs/design/coreclr/jit/finally-optimizations.md
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ Empirical studies have shown that most finallys are small. Thus to
avoid excessive code growth, a crude size estimate is formed by
counting the number of statements in the blocks that make up the
finally. Any finally larger that 15 statements is not cloned. In our
study this disqualifed about 0.5% of all finallys from cloning.
study this disqualified about 0.5% of all finallys from cloning.

### EH Nesting Considerations

Expand Down Expand Up @@ -416,7 +416,7 @@ blocks. Clear the finally target bit and any GT_END_LFIN from the
continuation.

If all call finallys are converted, modify the region to be try/fault
(interally EH_HANDLER_FAULT_WAS_FINALLY, so we can distinguish it
(internally EH_HANDLER_FAULT_WAS_FINALLY, so we can distinguish it
later from "organic" try/faults). Otherwise leave it as a
try/finally.

Expand Down
4 changes: 2 additions & 2 deletions docs/design/coreclr/jit/first-class-structs.md
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ This would be done in multiple phases:
* This work item should address issue [#4323 RyuJIT properly optimizes structs with a single field
if the field type is int but not if it is double](https://github.com/dotnet/runtime/issues/4323)
(test is `JIT\Regressions\JitBlue\GitHub_1161`),
[#7200 Struct getters are generating unneccessary
[#7200 Struct getters are generating unnecessary
instructions on x64 when struct contains floats](https://github.com/dotnet/runtime/issues/7200)
and [#11413 Inefficient codegen for casts between same size types](https://github.com/dotnet/runtime/issues/11413).
* Remove the pessimization in `LocalAddressVisitor::PostOrderVisit()` for the `GT_RETURN` case.
Expand Down Expand Up @@ -347,7 +347,7 @@ The following issues illustrate some of the motivation for improving the handlin
* Unfortunately, there is not currently a scenario or test case for this issue.

* [\#10879 Unix: Unnecessary struct copy while passing struct of size <=16](https://github.com/dotnet/runtime/issues/10879)
* [\#9839 [RyuJIT] Eliminate unecessary copies when passing structs](https://github.com/dotnet/runtime/issues/9839)
* [\#9839 [RyuJIT] Eliminate unnecessary copies when passing structs](https://github.com/dotnet/runtime/issues/9839)
* These require changing both the callsite and the callee to avoid copying the parameter onto the stack.
* It may be that these have been addressed by [PR #43870](https://github.com/dotnet/runtime/pull/43870).

Expand Down
2 changes: 1 addition & 1 deletion docs/design/coreclr/jit/inline-size-estimates.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ to be practical.
Second, even if we could obtain the actual size of prospective inline
candidates, we might not want to use this data. The final code
sequence emitted by the compiler depends intimately on details of the
target architecture, runtime conventions (ABIs), and capabilites of the
target architecture, runtime conventions (ABIs), and capabilities of the
compiler phases that run after inlining. If we allow feedback into hey
heuristics by incorporating data from these "downstream" sources, we
introduce various forms of coupling that have important
Expand Down
2 changes: 1 addition & 1 deletion docs/design/coreclr/jit/investigate-stress.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ Enabling GC Hole Stress causes GCs to always occur in specific locations and tha

**0x1 | 0x2** &ndash; 0x3 are "in the VM". Failures in 0x1 or 0x2 can be due to VM-related reasons, like lack of GC reporting/pinning in interop frames.

**0x4 | 0x8** &ndash; 0xC runs GC stress for each JIT generated instruction (either dynamically or AOT, in R2R). Failures in 0x4 or 0x8 typically mean a failure in GC info. Only happens once for any instruction, so can miss failures that only occur on non-first GCs. This mode replaces the target instuction with a with breakpoint instruction and that affects disassembly.
**0x4 | 0x8** &ndash; 0xC runs GC stress for each JIT generated instruction (either dynamically or AOT, in R2R). Failures in 0x4 or 0x8 typically mean a failure in GC info. Only happens once for any instruction, so can miss failures that only occur on non-first GCs. This mode replaces the target instruction with a with breakpoint instruction and that affects disassembly.
Loading