Skip to content

Conversation

purcell
Copy link
Contributor

@purcell purcell commented Mar 7, 2015

Neither eieio nor tabulated-list are installable packages, so depending on them leads to odd installation failures in some cases: purcell/emacs.d#255

This commit declares a dependency on Emacs 24 instead.

Neither `eieio` nor `tabulated-list` are installable packages, so depending on them leads to odd installation failures in some cases: purcell/emacs.d#255

This commit declares a dependency on Emacs 24 instead.
@m3nthal
Copy link

m3nthal commented Mar 7, 2015

Sorry, my mistake. Sent to a wrong project.

@sigma
Copy link
Collaborator

sigma commented Mar 8, 2015

I'm going to accept that because I don't want to support emacs 23 anymore, but that sounds like a package.el issue really (well, the "odd" part anyway, installation failure has to be expected): dependencies that package.el doesn't know how to resolve are a fact of life and should be dealt with gracefully.

Note that tabulated-list is installable, I explicitly made sure of it: https://marmalade-repo.org/packages/tabulated-list
It's just that not every ELPA repository knows about it.

sigma added a commit that referenced this pull request Mar 8, 2015
@sigma sigma merged commit 2e57045 into defunkt:master Mar 8, 2015
@purcell
Copy link
Contributor Author

purcell commented Mar 8, 2015

I'm going to accept that because I don't want to support emacs 23 anymore, but that sounds like a package.el issue really (well, the "odd" part anyway, installation failure has to be expected): dependencies that package.el doesn't know how to resolve are a fact of life and should be dealt with gracefully.

Yeah, I agree it's not ideal. The main problem here is that eieio is uninstallable, so Emacs 23 users would see that dependency failure and go looking for it, only to discover that it's built-in in Emacs 24. So changing the dependency makes that more explicit.

Note that tabulated-list is installable, I explicitly made sure of it: https://marmalade-repo.org/packages/tabulated-list
It's just that not every ELPA repository knows about it.

Cool -- where does the backport live? I can add it to MELPA.

@sigma
Copy link
Collaborator

sigma commented Mar 8, 2015

@purcell
Copy link
Contributor Author

purcell commented Mar 8, 2015

Oh - my mistake: we already have it: http://melpa.org/#/tabulated-list & http://stable.melpa.org/#/tabulated-list.

@purcell
Copy link
Contributor Author

purcell commented Mar 8, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants