[Spark] Remove waiting for a fixed time for Delta Connect Server to be available in Delta Connect testing #3576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longvu-db
changed the title
longvu-db
changed the title
longvu-db
changed the title
longvu-db
changed the title
longvu-db
commented
Aug 21, 2024
...-connect/client/src/test/scala-spark-master/io/delta/connect/tables/RemoteSparkSession.scala
Outdated
Show resolved
Hide resolved
Collaborator
tomvanbussel
left a comment
tomvanbussel
left a comment
There was a problem hiding this comment.
Not sure why these changes are necessary. The retry policy is already the default. Wouldn't just removing the sleep be enough?
spark-connect/client/src/test/scala-spark-master/io/delta/connect/tables/DeltaTableSuite.scala
Outdated
Show resolved
Hide resolved
...-connect/client/src/test/scala-spark-master/io/delta/connect/tables/RemoteSparkSession.scala
Outdated
Show resolved
Hide resolved
...-connect/client/src/test/scala-spark-master/io/delta/connect/tables/RemoteSparkSession.scala
Outdated
Show resolved
Hide resolved
tomvanbussel
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
For local E2E Delta Connect testing, we also designed an util class to start a local server in a different process similar to SparkConnect.
We noticed that the server takes a random amount of seconds to start up, and back then we received the error
INVALID_HANDLE.SESSION_NOT_FOUND] The handle 746e6c86-9fa9-4b08-9572-388c20eaed47 is invalid. Session not found. SQLSTATE: HY000", so what we did is to add a 10sThread.sleepbefore starting the client.This is not robust, so we are removing the
Thread.sleep. This should work because:SparkConnectClientwhich includes a default retry policy.INVALID_HANDLE.SESSION_NOT_FOUNDin this PR at some point, so we should be able to retry even if encountering this error.How was this patch tested?
Existing UTs.
Ran
build/sbttests locally at least 20 times.Does this PR introduce any user-facing changes?
No.