[Kernel] Vibe-coded prototype: Kernel postCommitSnapshot, UC publish (aka backfill) operation, with E2E test #5213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
changed the title
scottsand-db
commented
Sep 16, 2025
| * @return the highest contiguous version that was successfully published, or -1 if no commits | ||
| * were published or this is a filesystem-managed table | ||
| */ | ||
| default long publish(Engine engine, Snapshot snapshot) { |
Collaborator
Author
There was a problem hiding this comment.
This could just be: long publish(Engine engine, List<ParsedLogData> ratifiedCommits).
Then we don't need Snapshot::getRatifiedCommits.
But then we need some additional metadata to pass into publish, just like how we have CommitMetadata --> perhaps we could have PublishMetadata
scottsand-db
commented
Sep 16, 2025
| * this is not a time-travel-by-timestamp query | ||
| */ | ||
| private SnapshotQueryContext( | ||
| protected SnapshotQueryContext( |
Collaborator
Author
There was a problem hiding this comment.
@allisonport-db I think we might want to refactor this to be more extensible FYI
scottsand-db
commented
Sep 16, 2025
| * @throws UnsupportedOperationException if the implementation doesn't support file copying | ||
| * @since 3.4.0 | ||
| */ | ||
| default void copy(String srcPath, String destPath, boolean overwrite) throws IOException { |
Collaborator
Author
There was a problem hiding this comment.
Does this need to be in Kernel-APi?
5 tasks
scottsand-db
added a commit
that referenced
this pull request
Oct 1, 2025
## 🥞 Stacked PR Use this [link](https://github.com/delta-io/delta/pull/5262/files) to review incremental changes. - [**stack/kernel_post_commit_snapshot_1_log_segment_extension**](#5262) [[Files changed](https://github.com/delta-io/delta/pull/5262/files)] - [stack/kernel_post_commit_snapshot_2_snapshot_extension](#5280) [[Files changed](https://github.com/delta-io/delta/pull/5280/files/94155a89873b25094372f2de53e3c9346e7e6296..4b5dd1cec83f66a4d7ae70461d9ad479b3263944)] --------- #### Which Delta project/connector is this regarding? - [ ] Spark - [ ] Standalone - [ ] Flink - [X] Kernel - [ ] Other (fill in here) ## Description This PR adds two new internal LogSegment APIs that will help us create updated LogSegments after a transaction. This is PR 1 as part of the post-commit-snapshot effort. For the e2e prototype that has already derisked all of this, please see #5213 ## How was this patch tested? New UTs. ## Does this PR introduce _any_ user-facing changes? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
How was this patch tested?
Does this PR introduce any user-facing changes?