fix: deserialization issue with #[serde(flatten)]
#104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
May 1, 2025
| E: de::Error, | ||
| { | ||
| Ok(Vec::new()) | ||
| } |
Member
Author
There was a problem hiding this comment.
Seemed ok to add it here too?
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a deserialization issue with #[serde(flatten)] by adding proper handling for unit values in the relevant deserializer visitors and introducing a test to verify the deserialization behavior.
- Implements a new visit_unit method for two visitor structs to correctly handle unit deserialization.
- Adds a new test to validate that deserialization of a struct with a flattened field works as expected.
Comments suppressed due to low confidence (1)
src/registry.rs:1301
- [nitpick] The test function name 'example_deserialization_fail' is misleading since the test asserts that deserialization is successful. Consider renaming it (e.g., to 'example_deserialization_success') to reflect the expected outcome more clearly.
fn example_deserialization_fail() {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: nathanwhit [email protected]