Revert Python file fetching change #1420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feelepxyz
approved these changes
Oct 2, 2019
Contributor
feelepxyz
left a comment
feelepxyz
left a comment
There was a problem hiding this comment.
Ah nice one @greysteil! So the previous fix was for a project that wouldn't have worked with pip in the first place?
Contributor
Author
|
Exactly - they were trying to use a top level |
Contributor
|
Good to know! Thanks, @greysteil! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1419.
Looking at aio-libs/aiohttp#4122, I think we got this one wrong. Pip itself doesn't take into account the directory that nested requirement files are in - it concatenates the cascading requirements into a single file and treats all of the lines as if they were written at that level.