Merge updates.

.github/workflows/coding-standards.yml

@@ -1,4 +1,4 @@
-name: PHP Coding standards
+name: Coding Standards
 
 on:
   push:
@@ -16,11 +16,11 @@ jobs:
   # - Logs debug information.
   # - Installs Composer dependencies (from cache if possible).
   # - Logs PHP_CodeSniffer debug information.
-  # - Runs PHPCS tests.
-  # - todo: Add a PHP_CodeSniffer scan for the `tests` directory that does not suppress warnings.
+  # - Runs PHPCS on the full codebase with warnings suppressed.
+  # - Runs PHPCS on the `tests` directory without warnings suppressed.
   # - todo: Configure Slack notifications for failing scans.
   phpcs:
-    name: Check PHP coding standards
+    name: PHP coding standards
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
@@ -45,6 +45,7 @@ jobs:
         with:
           php-version: "latest"
           coverage: none
+          tools: composer, cs2pr
 
       - name: Log debug information
         run: |
@@ -59,11 +60,60 @@ jobs:
       - name: Log PHPCS debug information
         run: phpcs -i
 
-      - name: Run PHPCS on Core files
-        uses: wearerequired/lint-action@v1
+      - name: Run PHPCS on all Core files
+        run: vendor/bin/phpcs -q -n --report=checkstyle | cs2pr
+
+      - name: Check test suite files for warnings
+        run: vendor/bin/phpcs tests -q --report=checkstyle | cs2pr
+
+  # Runs the JavaScript coding standards checks.
+  #
+  # Performs the following steps:
+  # - Checks out the repository.
+  # - Logs debug information about the runner container.
+  # - Sets up caching for NPM.
+  # - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
+  # - Logs updated debug information.
+  # _ Installs NPM dependencies.
+  # - Run the WordPress JSHint checks.
+  # - todo: Configure Slack notifications for failing tests.
+  jshint:
+    name: JavaScript coding standards
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v2
+
+      - name: Log debug information
+        run: |
+          npm --version
+          node --version
+          git --version
+          svn --version
+
+      - name: Cache NodeJS modules
+        uses: actions/cache@v2
+        env:
+          cache-name: cache-node-modules
+        with:
+          # npm cache files are stored in `~/.npm` on Linux/macOS
+          path: ~/.npm
+          key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-npm-
+
+      - name: Install NodeJS
+        uses: actions/setup-node@v1
         with:
-          github_token: ${{ secrets.github_token }}
-          check_name: PHP-Coding-Standards-${linter}
-          php_codesniffer: true
-          # Ignore warnings
-          php_codesniffer_args: "-n"
+          node-version: 12
+
+      - name: Log debug information
+        run: |
+          npm --version
+          node --version
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Run JSHint
+        run: npm run grunt jshint

.github/workflows/end-to-end-tests.yml

@@ -6,14 +6,13 @@ on:
 
 env:
   LOCAL_DIR: build
-  PHP_FPM_UID: 1001 # This needs to be dynamic
-  PHP_FPM_GID: 116 # This needs to be dynamic
 
 jobs:
   # Runs the end-to-end test suite.
   #
   # Performs the following steps:
   # - Cancels all previous workflow runs that have not completed.
+  # - Set environment variables.
   # - Checks out the repository.
   # - Logs debug information about the runner container.
   # - Sets up caching for NPM.
@@ -36,6 +35,11 @@ jobs:
         with:
           access_token: ${{ github.token }}
 
+      - name: Configure environment variables
+        run: |
+          echo "PHP_FPM_UID=$(id -u)" >> $GITHUB_ENV
+          echo "PHP_FPM_GID=$(id -g)" >> $GITHUB_ENV
+
       - name: Checkout repository
         uses: actions/checkout@v2
 

.github/workflows/javascript-tests.yml

@@ -1,4 +1,4 @@
-name: JavaScript Standards & Tests
+name: JavaScript Tests
 
 on:
   push:
@@ -15,7 +15,7 @@ jobs:
   # - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
   # - Logs updated debug information.
   # _ Installs NPM dependencies.
-  # - Run the WordPress JavaScript coding standards checks and QUnit tests.
+  # - Run the WordPress QUnit tests.
   # - todo: Configure Slack notifications for failing tests.
   test-js:
     name: QUnit Tests
@@ -61,4 +61,4 @@ jobs:
         run: npm ci
 
       - name: Run QUnit tests
-        run: npm run grunt travis:js
+        run: npm run grunt qunit:compiled

.github/workflows/php-compatibility.yml

@@ -0,0 +1,62 @@
+name: PHP Compatibility
+
+on:
+  push:
+  pull_request:
+
+jobs:
+
+  # Runs PHP compatibility testing.
+  #
+  # Violations are reported inline with annotations.
+  #
+  # Performs the following steps:
+  # - Checks out the repository.
+  # - Configures caching for Composer.
+  # - Sets up PHP.
+  # - Logs debug information about the runner container.
+  # - Installs Composer dependencies (from cache if possible).
+  # - Logs PHP_CodeSniffer debug information.
+  # - Runs the PHP compatibility tests.
+  # - todo: Configure Slack notifications for failing scans.
+  php-comatibility:
+    name: Check PHP compatibility
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v2
+
+      - name: Get Composer cache directory
+        id: composer-cache
+        run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+
+      - name: Set up Composer caching
+        uses: actions/cache@v2
+        env:
+          cache-name: cache-composer-dependencies
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-composer-
+
+      - name: Set up PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: "latest"
+          coverage: none
+          tools: composer, cs2pr
+
+      - name: Log debug information
+        run: |
+          php --version
+          composer --version
+
+      - name: Install Composer dependencies
+        run: |
+          composer install --prefer-dist --no-suggest --no-progress --no-ansi --no-interaction
+          echo "vendor/bin" >> $GITHUB_PATH
+
+      - name: Run PHP compatibility tests
+        run: vendor/bin/phpcs --standard=phpcompat.xml.dist -q --report=checkstyle | cs2pr