Provide a codefix for legacy service usage and add tests #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
🧪 Details on Ubuntu 24.04.3 LTSfrom dotnet-retest v1.0.0 on .NET 10.0.1 with 💜 by @devlooped |
kzu
force-pushed
the
dev/codefix
branch
2 times, most recently
from
4627b4b to
1741be0
Compare
The codefix should be helpful in migrating larger codebases that used the previous approach (since we allow batch fixing in an entire solution). The added project also means we need a separate packaging project (can't reference the codefix project from the analyzer one because that can cause the analyzer to not load in the reduced scope of the compiler). The codefix project is only intended by consumption by an editor that can apply fixes. We now have a standalone packaging project that contains the eula and readme plus references to the other two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codefix should be helpful in migrating larger codebases that used the previous approach (since we allow batch fixing in an entire solution).
The added project also means we need a separate packaging project (can't reference the codefix project from the analyzer one because that can cause the analyzer to not load in the reduced scope of the compiler). The codefix project is only intended by consumption by an editor that can apply fixes.
We now have a standalone packaging project that contains the eula and readme plus references to the other two.