Skip to content

Allow updating messages in storage #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzu merged 1 commit into from
Jun 25, 2025
Merged

Allow updating messages in storage #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Tests/ConversationStorageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,15 @@ await storage.SaveAsync(new ContentMessage(
Assert.NotNull(text.AdditionalProperties);
Assert.Equal("ContentValue", (string)text.AdditionalProperties["ContentProp"]!);
}

message.AdditionalProperties?["Agent"] = "Calendar";

await storage.SaveAsync(message);
Copy link

Copilot AI Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test calls SaveAsync without providing a CancellationToken, but the implementation requires one. Either add an overload with a default token or update the test to pass a valid CancellationToken.

Copilot uses AI. Check for mistakes.

var updatedMessage = await storage.GetMessageAsync(user.Number, messageId);

Assert.NotNull(updatedMessage?.AdditionalProperties);
Assert.Equal("Calendar", updatedMessage.AdditionalProperties?["Agent"]);
Assert.Equal("MessageValue", (string)updatedMessage.AdditionalProperties!["MessageProp"]!);
}
}
1 change: 1 addition & 0 deletions src/Tests/Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<LangVersion>Preview</LangVersion>
Copy link

Copilot AI Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Requiring the C# Preview language version in tests may introduce instability; consider targeting a specific stable LangVersion unless new preview features are strictly needed.

Suggested change
<LangVersion>Preview</LangVersion>
<LangVersion>latest</LangVersion>

Copilot uses AI. Check for mistakes.

<IsPackable>false</IsPackable>
<IsTestProject>true</IsTestProject>
Expand Down
11 changes: 10 additions & 1 deletion src/WhatsApp/ConversationStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,16 @@ public async Task SaveAsync(IMessage message, CancellationToken cancellationToke
var conversation = await conversationsRepository.Value.GetAsync(message.UserNumber, message.ConversationId, cancellationToken) ??
new(message.UserNumber, message.ConversationId, [], message.Timestamp);

conversation.Messages.Add(message);
if (conversation.Messages.FirstOrDefault(x => x.Id == message.Id) is { } existing)
{
// Message is being updated, so we can just replace it
var index = conversation.Messages.IndexOf(existing);
conversation.Messages[index] = message;
}
else
{
conversation.Messages.Add(message);
}

// Save the conversation
await conversationsRepository.Value.PutAsync(conversation, cancellationToken);
Expand Down