Refactored handlers to return async enum responses #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kzu
reviewed
May 23, 2025
adalon
force-pushed
the
dev/adalonso/RefactorHandlers
branch
2 times, most recently
from
ca29304 to
9b4dba0
Compare
adalon
changed the title
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the WhatsApp handlers to return asynchronous enumerable responses, enhancing flexibility and scalability in message processing. Key changes include the transition from Task-based to IAsyncEnumerable-based handler methods, the propagation of cancellation tokens in client operations, and updates in test and sample implementations to work with async enumerables.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/WhatsApp/WhatsAppHandler.cs | Refactored handler implementation to return IAsyncEnumerable. |
| src/WhatsApp/WhatsAppClientExtensions.cs | Updated extension methods to include cancellation tokens and adjust parameter signatures. |
| src/WhatsApp/WhatsAppClient.cs | Added cancellation token propagation in SendAsync operations. |
| src/WhatsApp/OpenTelemetryHandler.cs | Updated error handling via WithErrorHandlingAsync in the tracing handler. |
| src/SampleApp/Sample/Program.cs | Modified sample app to iterate asynchronous responses and updated service configuration. |
Comments suppressed due to low confidence (1)
src/WhatsApp/WhatsAppClientExtensions.cs:6
- The accessibility of the WhatsAppClientExtensions class was changed from public to internal by removing the public modifier. Confirm that this intentional change will not restrict its usage across assemblies if it was designed to be a public API.
static partial class WhatsAppClientExtensions
In preparation for adding the storage handler.
kzu
force-pushed
the
dev/adalonso/RefactorHandlers
branch
from
bb2241b to
73bb13a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the Pull Request
The purpose of this pull request is to refactor the handlers in the WhatsApp project to return asynchronous enumerable responses. This change prepares the codebase for adding a storage handler, improving the flexibility and scalability of the message-handling pipeline.
Impact and Potential Risks
This pull request involves significant changes across multiple files, including modifications to the message-handling logic, interfaces, and tests. The use of asynchronous enumerables may introduce risks related to error handling and cancellation token propagation, as highlighted in the discussions. However, these changes align with modern asynchronous programming practices, which should improve performance and resource usage.