Skip to content

Conversation

@kzu
Copy link
Member

@kzu kzu commented Jun 4, 2025

No description provided.

@kzu kzu requested review from adalon and Copilot June 4, 2025 21:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements minor renames and documentation fixes across WhatsApp response-related classes, improving naming consistency.

  • Renamed parameter "ServiceId" to "Service" in XML documentation and corresponding signatures
  • Updated extension methods and accessibility levels for better API clarity

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/WhatsApp/TextResponse.cs Renamed doc parameter from "ServiceId" to "Service"
src/WhatsApp/TemplateResponse.cs Renamed doc parameter from "ServiceId" to "Service"
src/WhatsApp/Response.cs Renamed doc parameter from "ServiceId" to "Service" and adjusted the record signature
src/WhatsApp/ReactionResponse.cs Renamed doc parameter from "ServiceId" to "Service"
src/WhatsApp/MessageExtensions.cs Renamed extension method "TextWithButtons" to "Text" and changed accessibility for TrySingle
src/SampleApp/Sample/Program.cs Updated call site to use the new "Text" extension method
Comments suppressed due to low confidence (2)

src/WhatsApp/MessageExtensions.cs:45

  • Changing the accessibility of TrySingle from public to internal may affect downstream consumers. Confirm that this change is intentional and that all external usages are accounted for.
internal static bool TrySingle(this IEnumerable<IMessage> messages, [NotNullWhen(true)] out IMessage? message)

src/WhatsApp/MessageExtensions.cs:31

  • [nitpick] Renaming the overload originally named 'TextWithButtons' to 'Text' may lead to ambiguity when used alongside the other 'Text' extension. Consider reverting to a distinct name like 'TextWithButtons' to clarify its intent.
public static TextResponse Text(this Message message, string text, Button button1, Button? button2 = default)

@kzu
Copy link
Member Author

kzu commented Jun 4, 2025

32 passed 32 passed 7 skipped

🧪 Details on Ubuntu 24.04.2 LTS

from dotnet-retest v0.7.1 on .NET 8.0.16 with 💜 by @devlooped

@kzu kzu merged commit 20c3b3d into main Jun 5, 2025
8 checks passed
@kzu kzu deleted the dev/nitpick branch June 5, 2025 22:59
@devlooped devlooped locked and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants