Skip to content
This repository was archived by the owner on Dec 12, 2021. It is now read-only.
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add default for Builder limit
If the limit is not explicitly set on the Builder then we get the error, "Devloops\LaravelTypesense\Engines\TypesenseSearchEngine::buildSearchParams(): Argument #3 ($perPage) must be of type int, null given". Here's a fix that works but I'd understand if you have another way that works. I hardcoded the limit to 10 because that's the Typesense default for the per_page argument: https://typesense.org/docs/0.21.0/api/documents.html#arguments.
  • Loading branch information
kdevan authored Oct 19, 2021
commit b62e3380cb9c417d3810b21f0b0e68f72355103b
6 changes: 3 additions & 3 deletions src/Engines/TypesenseSearchEngine.php
Original file line number Diff line number Diff line change
Expand Up @@ -132,17 +132,17 @@ public function paginate(Builder $builder, $perPage, $page): mixed
/**
* @param \Laravel\Scout\Builder $builder
* @param int $page
* @param int $perPage
* @param int|null $perPage
*
* @return array
*/
private function buildSearchParams(Builder $builder, int $page, int $perPage): array
private function buildSearchParams(Builder $builder, int $page, ?int $perPage): array
{
$params = [
'q' => $builder->query,
'query_by' => implode(',', $builder->model->typesenseQueryBy()),
'filter_by' => $this->filters($builder),
'per_page' => $perPage,
'per_page' => $perPage ?? 10,
'page' => $page,
'highlight_start_tag' => $this->startTag,
'highlight_end_tag' => $this->endTag,
Expand Down