feat: Add ability to Link external helm app with devtron chart #1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manish-agrawal-ai
changed the title
manish-agrawal-ai
changed the title
manish-agrawal-ai
changed the title
nishant-d
suggested changes
Mar 15, 2022
| InstallApp(w http.ResponseWriter, r *http.Request) | ||
| GetInstalledAppsByAppStoreId(w http.ResponseWriter, r *http.Request) | ||
| DeleteInstalledApp(w http.ResponseWriter, r *http.Request) | ||
| UpdateHelmApplicationWithChartStoreLinking(w http.ResponseWriter, r *http.Request) |
Contributor
There was a problem hiding this comment.
better naming.
for already linked app update are we calling same method?
Contributor
Author
There was a problem hiding this comment.
name refactored.
For already app, we are not calling the same method. currently, update is happening externally to helm directly. we have to update link also. this item we have in our pipeline.
| //RBAC enforcer Ends | ||
|
|
||
| // check if chart repo is active starts | ||
| isChartRepoActive, err := handler.appStoreDeploymentService.IsChartRepoActive(int(request.GetAppStoreApplicationVersionId())) |
Contributor
There was a problem hiding this comment.
move this to service layer
| return nil, err | ||
| } | ||
|
|
||
| var appInstallationMode string |
Contributor
There was a problem hiding this comment.
we can directly assign the variable instead of if else
Contributor
Author
There was a problem hiding this comment.
if else is needed due to installAppVersionRequest.AppOfferingMode check in if condition
nishant-d
approved these changes
Mar 16, 2022
nishant-d
changed the title
nishant-d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of #1270
Description
Functionality added for :
Fixes #1270
Type of change
How Has This Been Tested?
By updating the helm App release with linking (API invoking)
Checklist: