Skip to content

WIP: Fix ingress new and legacy compatibility issues #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prakarsh-dt wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP: Fix ingress new and legacy compatibility issues #1349

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
631fd78
Update ingress.yaml
prakarsh-dt Mar 12, 2022
5bc72ea
updated ingress.yaml (#1527)
gunish-dt Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
updated ingress.yaml (#1527)
  • Loading branch information
@gunish-dt
gunish-dt authored Apr 21, 2022
commit 5bc72ea3d7cc40edb52d13324a7214cad09d4c68
4 changes: 4 additions & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_3-11-0/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ spec:
serviceName: {{ $svcName }}
servicePort: {{ $svcPort }}
{{- end }}
{{- if .Values.ingress.hosts }}
{{- range .Values.ingress.hosts }}
- host: {{ .host | quote }}
http:
Expand All @@ -39,6 +40,7 @@ spec:
servicePort: {{ $svcPort }}
{{- end }}
{{- end }}
{{- end }}
{{- if .Values.ingress.tls }}
tls:
{{ toYaml .Values.ingress.tls | indent 4 }}
Expand Down Expand Up @@ -72,6 +74,7 @@ spec:
serviceName: {{ $svcName }}
servicePort: {{ $svcPort }}
{{- end }}
{{- if .Values.ingressInternal.hosts }}
{{- range .Values.ingressInternal.hosts }}
- host: {{ .host | quote }}
http:
Expand All @@ -83,6 +86,7 @@ spec:
servicePort: {{ $svcPort }}
{{- end }}
{{- end }}
{{- end }}
{{- if .Values.ingressInternal.tls }}
tls:
{{ toYaml .Values.ingressInternal.tls | indent 4 }}
Expand Down
4 changes: 4 additions & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_3-12-0/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ spec:
serviceName: {{ $svcName }}
servicePort: {{ $svcPort }}
{{- end }}
{{- if .Values.ingress.hosts }}
{{- range .Values.ingress.hosts }}
- host: {{ .host | quote }}
http:
Expand All @@ -39,6 +40,7 @@ spec:
servicePort: {{ $svcPort }}
{{- end }}
{{- end }}
{{- end }}
{{- if .Values.ingress.tls }}
tls:
{{ toYaml .Values.ingress.tls | indent 4 }}
Expand Down Expand Up @@ -72,6 +74,7 @@ spec:
serviceName: {{ $svcName }}
servicePort: {{ $svcPort }}
{{- end }}
{{- if .Values.ingressInternal.hosts }}
{{- range .Values.ingressInternal.hosts }}
- host: {{ .host | quote }}
http:
Expand All @@ -83,6 +86,7 @@ spec:
servicePort: {{ $svcPort }}
{{- end }}
{{- end }}
{{- end }}
{{- if .Values.ingressInternal.tls }}
tls:
{{ toYaml .Values.ingressInternal.tls | indent 4 }}
Expand Down
4 changes: 4 additions & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_4-10-0/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ spec:
servicePort: {{ $svcPort }}
{{- end }}
{{- end }}
{{- if .Values.ingress.hosts }}
{{- range .Values.ingress.hosts }}
{{ $outer := . -}}
- host: {{ .host | quote }}
Expand All @@ -79,6 +80,7 @@ spec:
{{- end }}
{{- end }}
{{- end }}
{{- end }}
{{- if .Values.ingress.tls }}
tls:
{{ toYaml .Values.ingress.tls | indent 4 }}
Expand Down Expand Up @@ -131,6 +133,7 @@ spec:
servicePort: {{ $svcPort }}
{{- end }}
{{- end }}
{{- if .Values.ingressInternal.hosts }}
{{- range .Values.ingressInternal.hosts }}
{{ $outer := . -}}
- host: {{ .host | quote }}
Expand All @@ -153,6 +156,7 @@ spec:
{{- end }}
{{- end }}
{{- end }}
{{- end }}
{{- if .Values.ingressInternal.tls }}
tls:
{{ toYaml .Values.ingressInternal.tls | indent 4 }}
Expand Down