Skip to content

feat: Added ability to rollback a helm release #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nishant-d merged 18 commits into from
Mar 23, 2022
Merged

feat: Added ability to rollback a helm release #1359

nishant-d merged 18 commits into from
Mar 23, 2022

Conversation

@manish-agrawal-ai
Copy link
Contributor

@manish-agrawal-ai manish-agrawal-ai commented Mar 14, 2022 •
edited
Loading

Description

  1. Functionality added to rollback a helm release
  2. Helm app Deployment history API response change to support rollback helm release feature

Fixes # #1281

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

By hitting new Rollback release APIs and helm app deployment history APIs (for both full and hyperion mode)

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@manish-agrawal-ai manish-agrawal-ai changed the title Hyp 1281 feat: Added ability to rollback a helm release Mar 21, 2022
nishant-d
nishant-d suggested changes Mar 21, 2022
View reviewed changes
vikramdevtron
vikramdevtron reviewed Mar 21, 2022
View reviewed changes
Copy link
Contributor

@vikramdevtron vikramdevtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit cases for rollback

@manish-agrawal-ai
Copy link
Contributor Author

manish-agrawal-ai commented Mar 22, 2022

Unit testcase is not required. API testcases are needed.

@vikramdevtron
Copy link
Contributor

vikramdevtron commented Mar 23, 2022

@manish-agrawal-ai can we add template for this bug/feature ?

@nishant-d nishant-d merged commit 9b2252f into main Mar 23, 2022
@nishant-d nishant-d deleted the hyp_1281 branch March 23, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron vikramdevtron left review comments

+1 more reviewer

@nishant-d nishant-d nishant-d approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@manish-agrawal-ai @vikramdevtron @nishant-d