Skip to content

Conversation

@manish-agrawal-ai
Copy link
Contributor

@manish-agrawal-ai manish-agrawal-ai commented Apr 4, 2022

Description

If Linking an external helm chart gives error (from helm) then db operation should be rollback.

Fixes # #1381

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

by linking kubewatch chart

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@manish-agrawal-ai manish-agrawal-ai changed the title fix #1381 fix: Rollbacking DB operation if helm operation fails during linking with devtron chart Apr 4, 2022
@manish-agrawal-ai manish-agrawal-ai merged commit 2f8175b into main Apr 5, 2022
@manish-agrawal-ai manish-agrawal-ai deleted the 1381_fix branch April 5, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants