Update index.html #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have screenshot tests set up within Google that catch visual regressions for our components, but there seem no screenshot tests for the visual appearance when a component is rendered on the server. The visual appearance for components on the server is still important as the pre-rendered components should match the hydrated/active components visually as much as possible to avoid content flashing when the page becomes hydrated. We have paid attention to this in the past (e.g. for the form-field) and regressed a couple of times. A screenshot test should help avoiding such issues. Additionally it makes it easier to see how components look pre-rendered while also potentially giving us a heads-up if the hydrated component appearance changes. Note that MDC also seems to pay attention to SSR appearance of their components (hence their concept of non-upgraded and upgraded variants/CSS).
Owner
Author
|
d |
2 similar comments
Owner
Author
|
d |
Owner
Author
|
d |
Owner
Author
|
x |
Owner
Author
|
d |
Owner
Author
|
x |
1 similar comment
Owner
Author
|
x |
Owner
Author
|
s |
Owner
Author
|
/approve-ssr-golden |
6 similar comments
Owner
Author
|
/approve-ssr-golden |
Owner
Author
|
/approve-ssr-golden |
Owner
Author
|
/approve-ssr-golden |
Owner
Author
|
/approve-ssr-golden |
Owner
Author
|
/approve-ssr-golden |
Owner
Author
|
/approve-ssr-golden |
Owner
Author
|
/approve-ssr-golden |
2 similar comments
Owner
Author
|
/approve-ssr-golden |
Owner
Author
|
/approve-ssr-golden |
Owner
Author
|
/approve-sse-golden |
Owner
Author
|
/approve-ssr-golden |
1 similar comment
Owner
Author
|
/approve-ssr-golden |
devversion
force-pushed
the
ssr-test
branch
5 times, most recently
from
0598269 to
6a2e97d
Compare
devversion
force-pushed
the
ssr-test
branch
3 times, most recently
from
a4e8d33 to
46891c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.