-
Notifications
You must be signed in to change notification settings - Fork 96
feat: expose wasm-opt optimizer in ic-wasm to users
#3090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasm-opt optimizer in ic-wasm to userswasm-opt optimizer in ic-wasm to users
kentosugama
commented
Apr 19, 2023
kentosugama
commented
Apr 19, 2023
ghost
suggested changes
Apr 20, 2023
ghost
reviewed
Apr 20, 2023
ghost
approved these changes
Apr 21, 2023
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Approved assuming the update to ic-wasm 0.3.6 is applied. The rust e2e test failures will be fixed once #3099 is merged.
Contributor
Author
|
@ericswanson-dfinity Thank you for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LANG-124
Profiling data suggests that it would be useful to take advantage of the performance and binary size wasm optimizations offered by
wasm-opt.See also results in the canister profiling repo.
This tool has been integrated with
ic-wasmin this PR: dfinity/ic-wasm#28. The tool is added under theshrinkcommand that is currently used indfxto perform binary size reduction of canisters.The next step is to expose this feature to users by allowing users to opt into the optimizer and specify the optimization level in
dfx.json. Then to invokeic-wasmindfxaccording to this argument, similarly toshrink.Note: This tool has been used in the past to perform binary size reductions for canisters, but was replaced because it deletes the custom metadata sections from wasm modules. The
ic-wasmfeature invokeswasm-optwhile preserving these sections.Example usage in
dfx.json:How Has This Been Tested?
The following are
build.bashtests, ensuring that builds succeed with optimizations turned on, but that the feature is turned off by default, especially for custom canisters.The following is a test that ensures that
dfx startcorrectly rejects invalid optimization options indfx.json.Checklist: